1261896 - Show community support link on localized product landing pages

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, defect)

Description

[Kohei Yoshino [:kohei]]

Currently it's pretty difficult for Japanese Firefox/Thunderbird users to find the localized forum because there's no link to the "Get community support" page on each product. I thought it was there before; maybe regressed from Bug 1068720? Please enable the link for the Japanese (ja) locale in all products. We do have a localized page at https://support.mozilla.org/ja/kb/get-community-support that offers links to the localized forum as well as our enterprise support page. Thanks!

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I see the link '質問する' leading to https://support.mozilla.org/ja/kb/get-community-support in the top menu (very left). Or should it be somewhere else too?

Btw. as for the article l10n, I see there a button linking to https://support.mozilla.org/en-US/questions/new - maybe you want to point it to your local forum too.

Comment 2

[Kohei Yoshino [:kohei]]

The English equivalent https://support.mozilla.org/en-US/products/firefox has a prominent "Get community support" link in the Help Topics section. It's missing on localized pages including ja.

Comment 3

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Right, in the tiles, I understand now.

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: bug-1261896.patch

This would fix it, but I am not sure if it should be enabled globally for all locales and products, or it can be set from admin too without any code changes.

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Now it depends on
> questions_enabled(request.LANGUAGE_CODE)
so shows for locales with SUMO support forum enabled only.

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: GitHub PR

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Comment on attachment 8737920 [details] [diff] [review]
bug-1261896.patch

>From 93cbdd09b8bda9e3630988c3611804cb27803c1a Mon Sep 17 00:00:00 2001
>From: Michal Stanke <[e-mail]>
>Date: Mon, 4 Apr 2016 22:21:38 +0200
>Subject: [PATCH] [Bug 1261896] Show community support link for all products
> and locales
>
>---
> kitsune/products/jinja2/products/includes/topic_macros.html | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/kitsune/products/jinja2/products/includes/topic_macros.html b/kitsune/products/jinja2/products/includes/topic_macros.html
>index a8f1db2..8026055 100644
>--- a/kitsune/products/jinja2/products/includes/topic_macros.html
>+++ b/kitsune/products/jinja2/products/includes/topic_macros.html
>@@ -9,14 +9,12 @@
>       </a>
>     </li>
>     {% if loop.last %}
>-      {% if show_community_support %}
>         <li class="community-support">
>           <a href="{{ url('wiki.document', 'get-community-support') }}" class="cf">
>             <img src="{{ STATIC_URL }}sumo/img/blank.png" class="topic-icon" alt="" />
>             <span class="title">{{ _('Get community support') }}</span>
>           </a>
>         </li>
>-      {% endif %}
>       </ul>
>     {% endif %}
>   {% endfor %}
>-- 
>1.9.1
>

Comment 8

[Michael Cooper [:mythmon]]

I think this should only be shown for locales that have a translated version of get get-community-support page. I think we need to figure out what we want here before moving forward.

Vesper: What do you think about this?

Comment 9

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

A link to the article is in the menu instead of AAQ if the SUMO support forum is not opened for the locale, so I do not see a reason why to hide it here. (check https://support.mozilla.org/de/)

But it's true it does not check if the article is translated AFAIK.

Comment 10

[vesper]

I'm CCing Madalina and Rachel since this is directly connected to community support.

Madalina, Rachel: please take a look and decide where links to the forums should appear.

Comment 11

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Madalina, Rachel, what are your opinions?

Comment 12

[Kohei Yoshino [:kohei]]

This is not Japanese-specific issue.

Comment 13

[guigs [:guigs] PST (please needinfo me!)]

I agree it should be more obvious. If the english version appears in the AAQ I think the detected locale link should be there too. Thinking like a user I would see it and think "Oh, there is a forum in my language, I prefer that"

Comment 14

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

So beside adding the "Get community help" tile at the end of product list also to add a link to the redirect info shown e.g. here https://support.mozilla.org/de/questions/new ?

Comment 15

[madalina]

Makes sense to me to have the "Get community support" page added in the tiles. However we should only have it enabled for those locales who already have that page localized.

Comment 16

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Well, we do not have such check in the top menu (partially I guess because there is no possible fallback), but I hope I can implement it for the tiles.

Comment 17

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I have updated the PR to show the link for locales with AAQ enabled (the same behavior as now) or get-community-support article localized (requested behavior).

Waiting to know from Rachel, if the link should be added to the en-US fallback info, too.

Comment 18

[guigs [:guigs] PST (please needinfo me!)]

All good, all in on my side. I agree with Madalina to only show it if its localized.  Sorry for the delay here.

Comment 19

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

The patch has been already in the review process, but we are cautious to change the code and waiting for the platform decision, so we won't spend too much time with potentially never used changes. Thank you everyone for your patience. If Kitsune is chosen as SUMO platform for the future, this definitely needs to be fixed ASAP.

Comment 20

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: GitHub PR

Comment 21

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: GitHub PR

Comment 23

[Wayne Mery (:wsmwk)]

Nearing completion?

Comment 24

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Hi Wayne.

The patches are in the same state as in May 2016 - waiting for review until the codebase is unfreezed for new feature.

Giorgos, is there any ETA when the changed for Amazon migration are all done and there will be time to review also feature related patches?

Comment 25

[Giorgos Logiotatidis [:giorgos]]

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ][:mstanke] (use needinfo) from comment #24)
> Giorgos, is there any ETA when the changed for Amazon migration are all done
> and there will be time to review also feature related patches?

AWS migration is done. We now accept pull requests for features and fixes and will review the open ones as time allows.

Comment 26

[Ryan Lee Sipes]

Michal, perhaps we should review the PR, it looks like it needs to be updated (failing tests currently).

Comment 27

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Hi Ryan.

Thank you for getting in touch. I will try to revisit and rebase the PR soon. There are some conflicts that can cause the test failures, including the tests written as part of the patch. Keeping the NI.

Comment 28

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Hi Ryan.

I am very sorry, it took me so long. I have resolved the conflicts on GitHub, it should be ready now.

Comment 29

[Emil Ghitta, QA [:emilghitta]]

I believe that this issue is no longer valid now since SUMO went through a couple of UI changes since this bug was originally filled.

Reaching the https://support.mozilla.org/ja/kb/get-community-support page can be done for products via the "Still need help" page widgets.

I'm closing this ticket but please let me know if I've missed something.