1262160 - The application will crash when opening/exiting split screen feature

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Build: 3.0 (9), 4.0.(1)
Device: IPad Air 2 (iOS 9.2)

Steps to reproduce:
1. Launch Youtube application on IPad Air 2
2. Slide the screen left to open split screen feature and access wikipedia.org
3. Swipe left and right two times to enter and exit split screen mode
4. Press home button to minimize all aplications 
5. Again open Youtube app 
6. Swipe left to enter split screen mode
7. Open a new tab and access facebook.com
8. Swipe left and right to enter and exit split screen mode
9. Repeat step 8) several times and observe that the application will crash

Actual results:
- The application will crash

Please see a video of the issue at the following URL: https://www.youtube.com/watch?v=p8C25BZPuAw

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Pull request

The problem was caused by a pointer to an expired version of self in applicationDidEnterBackground during the execution of background tasks. Added [unowned self] to ensure self hung around long enough to execute those tasks

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8741320 [details] [review]
Pull request

Don't think the explanation or commit message here are accurate, so I'm not sure how this fix works. If you verified that this does fix the crash, though, (meaning the issue is somehow related to a retain cycle?) I'll happily r+ as-is with an updated message!

Comment 3

[Emily Toop (:fluffyemily)]

:bnicholson

When I returned to this I got a far more useful crash location and feel that this is a better fix.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8741320 [details] [review]
Pull request

LGTM!

Comment 6

[Simon Basca [:SimonB]]

Tested on build 0977e5b5

The issue is not reproducible following the above steps to reproduce.