Closed Bug 1262399 Opened 8 years ago Closed 8 years ago

remove Impl suffixes from nsSupports* implementations

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

Having the Impl suffix isn't really necessary, and if we start creating
instances of these classes directly, it's also rather ugly.  Let's get
rid of them.
Comment on attachment 8738505 [details] [diff] [review]
remove Impl suffixes from nsSupports* implementations

Review of attachment 8738505 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/ds/nsStringEnumerator.cpp
@@ +122,1 @@
>      if (!stringImpl) {

Redundant OOM checks here and below, if you want to remove that.
Attachment #8738505 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/ceb2fd9beec7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: