1263186 - Devtools preference devtools.errorconsole.enabled missing in Seamonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank-Rainer Grahl (:frg)]

Using latest trunk I get the folling error in the web console:

>> Timestamp: 4/8/2016 5:14:24 PM
>> Error: NS_ERROR_UNEXPECTED: Component returned failure code: 
>> 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]
>> Source File: chrome://navigator/content/webDeveloperOverlay.js
>> Line: 206

The preference does not exist in Sea Monkey.

VS2015 x64 en-US build
>> User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:48.0) 
>> Gecko/20100101 Firefox/48.0 SeaMonkey/2.45a1
>> Build identifier: 20160408154200

Comment 1

[Philip Chee]

Remove this:

    // Enable Error Console?
    var consoleEnabled = Services.prefs.getBoolPref("devtools.errorconsole.enabled");
    toggleCmd("Tools:ErrorConsole", consoleEnabled);

Also remove this:

    <command id="Tools:ErrorConsole" oncommand="toJavaScriptConsole()" disabled="true" hidden="true"/>

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1263186-errorconsole-remove.patch

The patch. Tested and seems to work.

Comment 3

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/abc74bba07dc

Comment 4

[:aceman]

What kind of Error console is this? Have they removed it from Firefox?

Comment 5

[Philip Chee]

(In reply to :aceman from comment #4)
> What kind of Error console is this? Have they removed it from Firefox?
This is the traditional toolkit Error Console. Bug 1258985 just removes the menu item from the Firefox Devtools UI. The Error Console itself is not affected. This should not affect Thunderbird since you aren't exposing the Devtools Client UI anyway.

Comment 6

[:aceman]

Thanks. So the console backend is still in Toolkit in for now and as we expose a link to it in the UI (tools->error console) it still works.