1263761 - Improve defaultSearch core-ping docs for custom search engines

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche

Review commit: https://reviewboard.mozilla.org/r/45605/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45605/

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8740168 [details]
MozReview Request: Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche

https://reviewboard.mozilla.org/r/45605/#review42261

Thanks for keeping the docs up-to-date.

::: toolkit/components/telemetry/docs/core-ping.rst:81
(Diff revision 1)
> +This field can also be ``null`` when a custom search engine is set as the
> +default.

```
... is set as the default (`bug XXX <https:// ...>`_ will fix this).
```

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/45605/#review42261

> ```
> ... is set as the default (`bug XXX <https:// ...>`_ will fix this).
> ```

This is actually intended to land after bug 1249288. See https://bugzilla.mozilla.org/show_bug.cgi?id=1249288#c75

I'm going to leave the comment the way it is.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/6c9c59550600d7523a7d58d23c1c9a6bce91b0f1
Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6c9c59550600