Closed Bug 1264386 Opened 8 years ago Closed 8 years ago

Heartbeat action should not use `navigator`

Categories

(Shield :: General, defect)

Product:
Shield
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mythmon, Unassigned)

Details

The current implementation of the Heartbeat action gets a list of plugins from the `navigator` global. This global won't be available in the addon (it would be a pain to implement, and it gives to much power to the actions).

This bug covers updating the driver spec to give actions a list of plugins, and updating the heartbeat action to use that instead of the `navigator` global.
Commits pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/29865fdba2a9f5ffbf77aafd50752723a86f56dd
[bug 1264386] Add plugin data to the client object.

https://github.com/mozilla/normandy/commit/da7533bdc76615d51fc6cb61e83fb6301fb79d5c
Merge pull request #116 from Osmose/plugins

[bug 1264386] Add plugin data to the client object.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: SHIELD → General
Product: Websites → Normandy
You need to log in before you can comment on or make changes to this bug.