Closed Bug 1265275 Opened 8 years ago Closed 3 years ago

[Presentation WebAPI] Remove "using namespace" from dom/presentation cpp files

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Version:
Firefox 83
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox48 --- affected

People

(Reporter: kershaw, Assigned: pctopgs, NeedInfo)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++] btpp-backlog)

Attachments

(12 files, 23 obsolete files)

New Patch for removing namsespace
3.79 KB, patch
kershaw
: review-
Details | Diff | Splinter Review
Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} from PresentationCallbacks.cpp. r=smaug
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationAvailability.cpp r=smaug
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 Removed using namespace mozilla; and using namespace mozilla::dom; from PresentationAvailability.cpp
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} from PresentationConnection.cpp r=smaug
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationTCPSessionTransport.cpp r=smaug
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 - Replaced using namespace mozilla; & using namespace mozilla::dom; with namespace mozilla{..} & namespace dom{..} in PresentationRequest.cpp. Added scope resolution to the NS_CreatePresentationService() definition in PresentationService.cpp
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 - Replaced using namespace mozilla; & using namespace mozilla::dom; with namespace mozilla{..} & namespace dom{..} in PresentationChild.cpp. r=hsivonen
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 - Replaced using namespace mozilla; & using namespace mozilla::dom; with namespace mozilla{..} & namespace dom{..} in PresentationIPCService.cpp.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 - Removed using namespace mozilla::ipc; from PresentationIPCService.cpp
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 - Removed using namespace mozilla::services; from PresentationSessionInfo.cpp
47 bytes, text/x-phabricator-request
Details | Review
Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' wih namespace mozilla {..} namespace dom {..} in PresentationSessionInfo.cpp r=smaug
47 bytes, text/x-phabricator-request
Details | Review 
As described in bug 1258602 comment #9, we should prevent importing all namespace.
Whiteboard: [good first bug]
Whiteboard: [good first bug] → [lang=c++][good first bug] btpp-backlog
Hello, Can I work on this bug? Can someone assign it to me and guide me to resolve it?
Flags: needinfo?(kechang)
(In reply to Akshay Jain from comment #1)
> Hello, Can I work on this bug? Can someone assign it to me and guide me to
> resolve it?

Sure.

You just need to remove "using namespace XXX;" from cpp files in dom/presentation and replace it by "namespace XXX {" like [1].

[1] https://dxr.mozilla.org/mozilla-central/source/dom/base/Crypto.cpp#20
Flags: needinfo?(kechang)
Assignee: nobody → ajain2
Hello Kershaw, thanks for that. I got it. I am a newbie so could you guide me through the steps of how to get this code on my local system so that I can start working on it immediately. I will appreciate your guidance. Thanks.
(In reply to Akshay Jain from comment #3)
> Hello Kershaw, thanks for that. I got it. I am a newbie so could you guide
> me through the steps of how to get this code on my local system so that I
> can start working on it immediately. I will appreciate your guidance. Thanks.

Here are some steps for you.
1. Build Firefox: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions
2. Summit a patch: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
3. Become a committer: https://www.mozilla.org/en-US/about/governance/policies/commit/
4. Push your patch to try server for testing: https://wiki.mozilla.org/ReleaseEngineering/TryServer

Those instructions might be out-of-date, so don't hesitate to let me know if you have any problem.
Hello Kershaw, I am working on the bug and encountered that in the file dom/presentation/PresentationService.cpp, the namespace are redundant. Is it something wrong or I am misinterpreting ?
(In reply to Akshay Jain from comment #5)
> Hello Kershaw, I am working on the bug and encountered that in the file
> dom/presentation/PresentationService.cpp, the namespace are redundant. Is it
> something wrong or I am misinterpreting ?

Yes, I think you are right. They are redundant.
Attached patch namespaces.patch (obsolete) — — Splinter Review 
No QA Mentor assigned. So can someone please review the Patch. No changes made to ../dom/presentation/PresentationService.cpp , /PresentationSessionInfo.cpp and ../dom/presentation/ipc/PresentationIPCService.cpp due to conflict in redundancy of using namespace and removing the redundancy results in build failure.
Thanks.
Flags: needinfo?(kechang)
(In reply to Akshay Jain from comment #7)
> Created attachment 8753668 [details] [diff] [review]
> namespaces.patch
> 
> No QA Mentor assigned. So can someone please review the Patch.

You can ask smaug (bugs@pettay.fi) to review your patch.

> No changes
> made to ../dom/presentation/PresentationService.cpp ,
> /PresentationSessionInfo.cpp and
> ../dom/presentation/ipc/PresentationIPCService.cpp due to conflict in
> redundancy of using namespace and removing the redundancy results in build
> failure.

For PresentationService.cpp and PresentationSessionInfo.cpp, I think you can just remove "using namespace mozilla;" and "using namespace mozilla::dom;".
Flags: needinfo?(kechang)
Hello
I want to work on it. This would be my first bug. Can somebody assign it to me
(In reply to Vivek Jain from comment #9)
> Hello
> I want to work on it. This would be my first bug. Can somebody assign it to
> me

I think Akshay had been working on this for a while. Not sure if he is still working now.

Akshay, could you update the status, please?
Flags: needinfo?(ajain2)
Comment on attachment 8753668 [details] [diff] [review]
namespaces.patch

Request for review due to Comment 8
Attachment #8753668 - Flags: review?(bugs)
Comment on attachment 8753668 [details] [diff] [review]
namespaces.patch

Totally ok to me if kershaw reviews this :)
Attachment #8753668 - Flags: review?(bugs) → review?(kechang)
Comment on attachment 8753668 [details] [diff] [review]
namespaces.patch

Review of attachment 8753668 [details] [diff] [review]:
-----------------------------------------------------------------

As comment #8, please also modify the files below. Thanks.

dom/presentation/PresentationService.cpp
dom/presentation/PresentationSessionInfo.cpp
dom/presentation/ipc/PresentationIPCService.cpp
Attachment #8753668 - Flags: review?(kechang)
Was looking for a first bug to tackle and this one only looked half fixed so I took a shot at fixing it.
Attachment #8771385 - Flags: review?(kechang)
Comment on attachment 8771385 [details] [diff] [review]
diff of changes made to "/dom/presentation" .cpp files where "using namespace XXX;" redundancy has been changed to just "namespace XXX {"

Review of attachment 8771385 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this. I have some comments below.

1. Please remove the *.orig in your patch.

2. We usually expect to see 8 lines of context in bugzilla.
Please add U8 option when creating your patch next time. Thanks.

::: dom/presentation/PresentationService.cpp
@@ +775,5 @@
>    return service.forget();
>  }
> +
> +} //namespace dom
> +} //namespace mozilla

We need to move the end of namespace declaration from http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/dom/presentation/PresentationService.cpp#60 to the end of PresentationService.cpp.

::: dom/presentation/PresentationSessionInfo.cpp
@@ +37,5 @@
>  #endif
>  
> +namespace mozilla {
> +namespace dom {
> +namespace services {

I think we just need to put everything inside namespace dom.
Please align the declaration in PresentationSessionInfo.h.

::: dom/presentation/ipc/PresentationIPCService.cpp
@@ +15,5 @@
>  #include "PresentationIPCService.h"
>  
> +namespace mozilla {
> +namespace dom {
> +namespace ipc {

Same here. Please align the declaration in PresentationIPCService.h.

::: dom/presentation/ipc/PresentationParent.cpp
@@ +13,4 @@
>  #include "PresentationService.h"
>  #include "PresentationSessionInfo.h"
>  
> +namespace dom {

We also need "namespace mozilla {".
Attachment #8771385 - Flags: review?(kechang)
Comment on attachment 8810204 [details] [diff] [review]
Made changes to "/dom/presentation" cpp files. Changed "using namespace xxx" to "namespace xxx {"

Review of attachment 8810204 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

Could you please also modify dom/presentation/PresentationCallbacks.cpp? Thanks.
Attachment #8810204 - Flags: review+
Attachment #8810204 - Attachment is obsolete: true
(In reply to Kershaw Chang [:kershaw] from comment #17)
> Comment on attachment 8810204 [details] [diff] [review]
> Made changes to "/dom/presentation" cpp files. Changed "using namespace xxx"
> to "namespace xxx {"
> 
> Review of attachment 8810204 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for doing this!
> 
> Could you please also modify dom/presentation/PresentationCallbacks.cpp?
> Thanks.

Sorry for missing one of the files in my first patch. 

I'm new to open source. Do you have any suggestions on what I should look at next, something with C++ preferably. Thanks.
Is this bug still up? Can i take it?
Please check my patch and do the needfull.
Attachment #8848713 - Flags: review?(bugs)
Attachment #8848713 - Flags: review?(bugs) → review?(kechang)
Comment on attachment 8848713 [details] [diff] [review]
New Patch for removing namsespace

Review of attachment 8848713 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/presentation/PresentationAvailability.cpp
@@ +14,5 @@
>  #include "nsServiceManagerUtils.h"
>  #include "PresentationLog.h"
>  
> +namespace mozilla{
> + namespace dom{

Please remove the unnecessary space.

@@ +186,5 @@
>    }
>  }
> +
> +}
> +

Extra new line.

::: dom/presentation/PresentationCallbacks.cpp
@@ +12,5 @@
>  #include "nsServiceManagerUtils.h"
>  #include "PresentationCallbacks.h"
>  #include "PresentationRequest.h"
>  #include "PresentationConnection.h"
> +#include "nsThreadUtils"

Missing ".h"

I believe this patch would not be compiled.

@@ +16,5 @@
> +#include "nsThreadUtils"
> +#include "PresentationCallbacks.h"
> +#include "PresentationRequest.h"
> +#include "PresentationConnection.h"
> +#include "PresentationTransportBuilderConstructor.h"

These files are already included in the original file.

::: dom/presentation/PresentationConnection.cpp
@@ +578,5 @@
>    return NS_OK;
>  }
> +
> +}
> +

Extra new line.
Please take a look at other files, such as [1].

http://searchfox.org/mozilla-central/source/dom/presentation/AvailabilityCollection.cpp
Attachment #8848713 - Flags: review?(kechang) → review-
Attachment #8753668 - Attachment is obsolete: true
Attachment #8771385 - Attachment is obsolete: true
Attachment #8810762 - Attachment is obsolete: true
Assignee: ajain2 → udayanbaidya
Priority: -- → P3
Component: DOM → DOM: Core & HTML

Hi,

I am interested to contribute to mozilla.
Possible for me to get started on this issue?

(In reply to rahul.rajesh.bhat from comment #23)

Hi,

I am interested to contribute to mozilla.
Possible for me to get started on this issue?

Sure. Feel free to take this.

Assignee: udayanbaidya → rahul.rajesh.bhat

Any guidance on where should I start?

Hi! I am new here.
I would like to take up this bug. Could you assign it to me?

Keywords: good-first-bug
Whiteboard: [lang=c++][good first bug] btpp-backlog → [lang=c++] btpp-backlog

It looks like Rahul hasn't been active in a while. Please pass the torch to me!

Sorry I forgot to add the request information tag.. Please assign this bug to me

Flags: needinfo?(kershaw)

I spoke to Rahul and he's no longer working this bug. Please assign it to me

Thanks for offering this help.

Assignee: rahul.rajesh.bhat → pctopgs
Flags: needinfo?(kershaw)
Attachment #9159946 - Attachment is obsolete: true
Attachment #9160404 - Attachment description: Bug 1265275 - ran mochitests after removing 'using namespace mozilla;' and 'using namespace mozilla::dom;' from PresentationCallbacks.cpp. r= → Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} from PresentationCallbacks.cpp.
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f66ea9c9d32
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} from PresentationCallbacks.cpp. r=smaug
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e13791863bbd
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationAvailability.cpp r=smaug

https://hg.mozilla.org/mozilla-central/rev/8f66ea9c9d32
https://hg.mozilla.org/mozilla-central/rev/e13791863bbd

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Status: RESOLVED → REOPENED
status-firefox80: fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla80 → ---
Attachment #9160404 - Attachment description: Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} from PresentationCallbacks.cpp. → Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} from PresentationCallbacks.cpp. r=smaug
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db0863a13452
Removed using namespace mozilla; and using namespace mozilla::dom; from PresentationAvailability.cpp r=smaug

https://hg.mozilla.org/mozilla-central/rev/db0863a13452

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Status: RESOLVED → REOPENED
status-firefox80: fixed → ---
Keywords: leave-open
Resolution: FIXED → ---
Target Milestone: mozilla80 → ---
Attachment #9161413 - Attachment is obsolete: true
Attachment #9161259 - Attachment is obsolete: true

I see that revisions were accepted but they're not landed yet. Do you need me to do something?

Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebde0955338e
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationConnection.cpp r=baku
https://hg.mozilla.org/integration/autoland/rev/50e3f43c30c4
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationRequest.cpp r=baku

Landed.

Flags: needinfo?(amarchesini)

Backed out 2 changesets (bug 1265275) for SynchronizedEventQueue.h related bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=build&fromchange=7df94b4f2b9f8d66120a754920f74e256418214a&tochange=8cd40a6531a05bcb1d0dc307075dd984236a7d8f&selectedTaskRun=XaRPiwb5S9CAPeUZZLwjdw.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/8cd40a6531a05bcb1d0dc307075dd984236a7d8f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309558230&repo=autoland&lineNumber=15365

[task 2020-07-13T08:13:58.610Z] 08:13:58     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/dom/presentation'
[task 2020-07-13T08:13:58.612Z] 08:13:58     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_dom_presentation0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/presentation -I/builds/worker/workspace/obj-build/dom/presentation -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_dom_presentation0.o.pp   Unified_cpp_dom_presentation0.cpp
[task 2020-07-13T08:13:58.612Z] 08:13:58     INFO -  In file included from Unified_cpp_dom_presentation0.cpp:101:
[task 2020-07-13T08:13:58.614Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationService.cpp:7:
[task 2020-07-13T08:13:58.614Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationService.h:12:
[task 2020-07-13T08:13:58.614Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationServiceBase.h:19:
[task 2020-07-13T08:13:58.614Z] 08:13:58     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsThread.h:19:
[task 2020-07-13T08:13:58.620Z] 08:13:58    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/SynchronizedEventQueue.h:48:30: error: no type named 'MallocSizeOf' in namespace 'mozilla::dom::mozilla'; did you mean simply 'MallocSizeOf'?
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -    size_t SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf) const {
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -                               ^~~~~~~~~~~~~~~~~~~~~
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -                               MallocSizeOf
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/MemoryReporting.h:22:18: note: 'MallocSizeOf' declared here
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -  typedef size_t (*MallocSizeOf)(const void* p);
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -                   ^
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -  In file included from Unified_cpp_dom_presentation0.cpp:101:
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationService.cpp:7:
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationService.h:12:
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationServiceBase.h:19:
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsThread.h:19:
[task 2020-07-13T08:13:58.620Z] 08:13:58    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/SynchronizedEventQueue.h:53:7: error: no type named 'MallocSizeOf' in namespace 'mozilla::dom::mozilla'; did you mean simply 'MallocSizeOf'?
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -        mozilla::MallocSizeOf aMallocSizeOf) const = 0;
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -        ^~~~~~~~~~~~~~~~~~~~~
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -        MallocSizeOf
[task 2020-07-13T08:13:58.620Z] 08:13:58     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/MemoryReporting.h:22:18: note: 'MallocSizeOf' declared here
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -  typedef size_t (*MallocSizeOf)(const void* p);
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -                   ^
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -  In file included from Unified_cpp_dom_presentation0.cpp:101:
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationService.cpp:7:
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationService.h:12:
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -  In file included from /builds/worker/checkouts/gecko/dom/presentation/PresentationServiceBase.h:19:
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsThread.h:19:
[task 2020-07-13T08:13:58.621Z] 08:13:58    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/SynchronizedEventQueue.h:40:3: error: no template named 'IsDestructible' in namespace 'mozilla::dom::mozilla'; did you mean simply 'IsDestructible'?
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -    NS_INLINE_DECL_THREADSAFE_REFCOUNTING(ThreadTargetSink)
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -  /builds/worker/workspace/obj-build/dist/include/nsISupportsImpl.h:727:3: note: expanded from macro 'NS_INLINE_DECL_THREADSAFE_REFCOUNTING'
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -    NS_INLINE_DECL_THREADSAFE_REFCOUNTING_WITH_DESTROY(_class, delete (this), \
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-07-13T08:13:58.621Z] 08:13:58     INFO -  /builds/worker/workspace/obj-build/dist/include/nsISupportsImpl.h:705:3: note: expanded from macro 'NS_INLINE_DECL_THREADSAFE_REFCOUNTING_WITH_DESTROY'
[task 2020-07-13T08:13:58.636Z] 08:13:58     INFO -    NS_INLINE_DECL_THREADSAFE_REFCOUNTING_META(_class, NS_METHOD_, _destroy,   \
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -  /builds/worker/workspace/obj-build/dist/include/nsISupportsImpl.h:669:5: note: expanded from macro 'NS_INLINE_DECL_THREADSAFE_REFCOUNTING_META'
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -      MOZ_ASSERT_TYPE_OK_FOR_REFCOUNTING(_class)                              \
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -  /builds/worker/workspace/obj-build/dist/include/nsISupportsImpl.h:33:18: note: expanded from macro 'MOZ_ASSERT_TYPE_OK_FOR_REFCOUNTING'
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -    static_assert(!mozilla::IsDestructible<X>::value,      \
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -                   ^~~~~~~~~
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/TypeTraits.h:103:8: note: 'IsDestructible' declared here
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -  struct IsDestructible : public detail::IsDestructibleImpl<T>::Type {};
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -         ^
[task 2020-07-13T08:13:58.637Z] 08:13:58     INFO -  In file included from Unified_cpp_dom_presentation0.cpp:101:
...
Flags: needinfo?(pctopgs)

It looks like the last push failed. Do I need to resubmit the patch to it can successfully land?

Flags: needinfo?(pctopgs) → needinfo?(amarchesini)

Correct. Fix the issue and push it to phab again. Flag me as a reviewer and we can land it again.
If you want to be 100% sure you do not introduce failures, you can push to try before asking me to review it.
If you want to talk about something more in detail, ping me on slack or matrix. Thanks!

Flags: needinfo?(amarchesini)
Attachment #9162519 - Attachment is obsolete: true
Attachment #9162517 - Attachment is obsolete: true
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36f1f780b0d7
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationRequest.cpp r=baku
https://hg.mozilla.org/integration/autoland/rev/8e3dd061717c
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationConnection.cpp r=baku

Hmm

Depends on D83924

Attachment #9165019 - Attachment is obsolete: true
Attachment #9161259 - Attachment is obsolete: false
Attachment #9164297 - Attachment is obsolete: true
Attachment #9164320 - Attachment is obsolete: true
Attachment #9161259 - Attachment is obsolete: true
Attachment #9165707 - Attachment is obsolete: true
Attachment #9165708 - Attachment is obsolete: true
Attachment #9165129 - Attachment is obsolete: true
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d028da4b51ee
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} from PresentationConnection.cpp r=smaug
Attachment #9166266 - Attachment is obsolete: true
Attachment #9167661 - Attachment description: Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationTCPSessionTransport.cpp r=baku → Bug 1265275 - Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationTCPSessionTransport.cpp r=smaug
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3db196d78b4f
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' and replaced them with namespace mozilla{...} and namespace dom{...} in PresentationTCPSessionTransport.cpp r=smaug

Thanks

Flags: needinfo?(pctopgs)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1de0bdfee4f
Replaced using namespace mozilla; & using namespace mozilla::dom; with namespace mozilla{..} & namespace dom{..} in PresentationRequest.cpp. Added scope resolution to the NS_CreatePresentationService() definition in PresentationService.cpp r=smaug
Attachment #9169413 - Attachment is obsolete: true
Attachment #9169412 - Attachment is obsolete: true
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c98860c25fc6
Replaced using namespace mozilla; & using namespace mozilla::dom; with namespace mozilla{..} & namespace dom{..} in PresentationChild.cpp. r=smaug
Attachment #9171156 - Attachment is obsolete: true
Attachment #9171155 - Attachment is obsolete: true
Attachment #9171158 - Attachment is obsolete: true
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bf8686371e3
Replaced using namespace mozilla; & using namespace mozilla::dom; with namespace mozilla{..} & namespace dom{..} in PresentationIPCService.cpp. r=smaug
https://hg.mozilla.org/integration/autoland/rev/49875c96fa20
Removed using namespace mozilla::ipc; from PresentationIPCService.cpp r=smaug
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c9f0eac6923
Removed using namespace mozilla::services; from PresentationSessionInfo.cpp r=smaug
Attachment #9178568 - Attachment is obsolete: true
Attachment #9178622 - Attachment is obsolete: true
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99d127d72384
Removed 'using namespace mozilla;' and 'using namespace mozilla::dom;' wih namespace mozilla {..} namespace dom {..} in PresentationSessionInfo.cpp r=smaug

I think this bug is finally complete!

Flags: needinfo?(kershaw)

(In reply to Donovan Thompson from comment #90)

I think this bug is finally complete!

Congrats!

Flags: needinfo?(kershaw)

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: pctopgs → nobody
Status: REOPENED → NEW
Assignee: nobody → pctopgs
Status: NEW → RESOLVED
Closed: 4 years ago → 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
Version: Trunk → Firefox 83
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: