1265710 - Consider using "Apple Touch Icons" in app UI (Instead of Favicons)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Some sites do only have ugly 16x16 favicons and nice apple touch icons. Facebook and YouTube for example.

So far we only use the touch icons for home screen shortcuts. Using them in the app would improve our icon quality significantly.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: icons_facebook_youtube.png

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Makes sense to me. 

Though, we should start being aware of all the different icons we'll be getting for popular sites. I think if we DON'T have it covered in Tippy Top (bug 1263707), then we should use these icons.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Before we can do that we need to fix our current favicon issues. Especially bug 1269821 and bug 1271634. Fixing those bugs might require restructuring the way we store and link favicons.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

While working on bug 1264901 I found a simpler way of using those icons. I'll prepare a patch.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: touch-icons-in-ui.png

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1265710 - Treat apple-touch-icons like favicons and use them in the app UI.

Originally I wanted to keep them as a separate type of icon and store them separately.
But this is much simpler and a big improvement. We wanted to treat touch icons as
better favicons anyways and making them go through the same pipeline gives us exactly
that.

Review commit: https://reviewboard.mozilla.org/r/57630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57630/

Comment 7

[Andrzej Hunt :ahunt]

Comment on attachment 8759762 [details]
Bug 1265710 - Treat apple-touch-icons like favicons and use them in the app UI.

https://reviewboard.mozilla.org/r/57630/#review54462

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3978ffc8e928
Treat apple-touch-icons like favicons and use them in the app UI. r=ahunt

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3978ffc8e928

Comment 10

[Sorina Florean [:sflorean]]

Attachment: Screenshot_2016-06-06-17-36-22.png

Verified as fixed in build 49.0a1 2016-06-06;
Device: LG G4 (Android 5.1).