1265772 - replace Services.console

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

Replace uses of Service.console as part of the de-chrome-ification project.

Comment 1

[Tom Tromey :tromey]

Of course I typod the name and it is "Services.console".

Comment 2

[Tom Tromey :tromey]

Attachment: use console.log, not Services.console.logStringMessage

MozReview-Commit-ID: Ax4EwhRVE0R

This fixes uses of Services.console, with a few minor exceptions:
* server/, of course
* shared/webconsole, where some seem to be related to the actor;
  the code is a bit intermingled here
* tests, but again as they are tests specifically for webconsole,
  maybe they can't be changed (I didn't look too deeply)

Comment 3

[Tom Tromey :tromey]

Attachment: MozReview Request: Bug 1265772 - don't use Services.console or Console.jsm in devtools; r?bgrins

Review commit: https://reviewboard.mozilla.org/r/48567/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48567/

Comment 4

[Tom Tromey :tromey]

I forgot to note - this removes Console.jsm uses from most, but not all, spots.
A few remain in other jsms, in loaders, and in tests.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8744478 [details]
MozReview Request: Bug 1265772 - don't use Services.console or Console.jsm in devtools; r?bgrins

https://reviewboard.mozilla.org/r/48567/#review45593

Works for me, thanks

Comment 6

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0daa5d45611c

Comment 7

[Tom Tromey :tromey]

Something went wrong with that try run, but here's a better one:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ea2b37ea3c072008e24da0b4583126206f9814b

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c5c28bffad82

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c5c28bffad82