1265895 - [MERGE] Update the alias field for the bug modal form

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[David Lawrence [:dkl]]

- the alias field shouldn't be moved from its current location, and should be a comma delimited list
    - moving the field into 'details' when editing is confusing/unexpected
    - displaying current aliases in a <select> is a no-go; i went to great pains to remove those from the current ui
        - they are ugly, and multi-select isn't obvious
        - when you demoed the ui to me in orlando i recall stating this wasn't a viable solution
    - make the alias field a comma separated list
        - bugs aren't expected to have a massive amount of aliases; we don't need a heavy ui to manage them
        - comma is already an invalid character in a bug alias

Comment 1

[David Lawrence [:dkl]]

Attachment: 1265895_1.patch

If you are pressed for time, punt this over to Dylan.

- Removed old alias form elements
- Added alias editing back to summary section as before
- Aliases act like cc list values in that when hovering, a X is displayed allowing to remove each.
- "Add" button displays an input to enter new comma separated alias values.

dkl

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8744072 [details] [diff] [review]
1265895_1.patch

Talking it over, dylan may have more time to look at this than glob, so retargetting.

Comment 3

[:glob ✱]

Comment on attachment 8744072 [details] [diff] [review]
1265895_1.patch

Review of attachment 8744072 [details] [diff] [review]:
-----------------------------------------------------------------

fwiw i don't agree that mirroring the CC approach is correct.
it's expected that bugs will have a small amount of aliases, so a comma separated list is all that's required.

::: extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl
@@ +192,5 @@
> +        label = "Alias"
> +        hide_on_view = 1
> +    %]
> +
> +      [% IF bug.check_can_change_field("alias", 0, 1) %]

if the current user can't edit the alias field, it should be displayed the same as the view mode instead of editable with controls removed.

try passing |hide_on_edit = NOT bug.check_can_change_field("alias", 0, 1)| to the field wrapper

::: extensions/BugModal/web/bug_modal.js
@@ +1084,5 @@
> +        });
> +    $('#alias-list .alias-remove')
> +        .click(function(event) {
> +            event.preventDefault();
> +            $('#top-save-btn').show();

you don't need to explicitly show the save buttons as these controls should only be visible when editing.

Comment 4

[David Lawrence [:dkl]]

Attachment: 1265895_2.patch

Ok. Much simpler patch this time around.

dkl

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8746714 [details] [diff] [review]
1265895_2.patch

Review of attachment 8746714 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 6

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
  d96b42b..87063bd  upstream-merge -> upstream-merge