1266437 - [UI Events] getModifierState("Meta") should return true when Windows logo key is pressed on Windows and Linux

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[dtapuska]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.112 Safari/537.36

Steps to reproduce:

The UI Events specification has changed

getModifierState("OS") has been removed as per change:
https://github.com/w3c/uievents-key/issues/9


Actual results:

event.meta returns false when the Windows Key is pressed.


Expected results:

event.meta returns true when Windows Key is pressed.
event.getModifierState("OS") should return false (because it shouldn't be supported)
event.getModifierState("Meta") should return true

Comment 2

[Jonathan Watt [:jwatt]]

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that on Linux, we should stop treating the legacy Meta modifier state of Linux as "Meta" of DOM. It's typically mapped to Shift - Alt, so, I think that it should be treated as "Alt".

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Intent to change: https://groups.google.com/a/mozilla.org/g/dev-platform/c/S859KrLKSBU

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1266437 - Drop "OS" modifier r=smaug!,m_kato!,karlt!,Gijs!,#dom-core

On Windows, Windows logo key was mapped to "OS" modifier, and on Linux,
it's same and the key is called "Super" and "Hyper". That conformed to the
older UI Events spec.

However, UI Events declares that they should be mapped to "Meta" now.
https://www.w3.org/TR/uievents-key/#key-Meta

And Chrome handles it as the spec in Windows and Linux. Therefore, we should
align the behavior to them.

Note that we've treated the legacy "Meta" modifier on Linux as DOM "Meta"
modifier state, but we should stop it for avoiding confusion. Typically,
it's mapped to Shift - Alt. So, mapping it to DOM "Alt" must be better.

Finally, those check only IsMeta() but not IsOS(). I think that they
should've checked IsOS() too. Therefore, they will behave differently
in Windows and Linux.

• https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/base/Element.cpp#3287-3288
• https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3762-3764
• https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3796-3806
• https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLLabelElement.cpp#127-128
• https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/widget/gtk/nsGtkKeyUtils.cpp#1461-1462

Depends on D183479

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The patch will be landed after the next merge (i.e., will be fixed in 118).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b56e99dd221
Drop "OS" modifier r=smaug,m_kato,karlt,Gijs

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a000f750445
Backed out 2 changesets (bug 1266437, bug 1232918) for causing mochitest failures in test_autoplay_policy_key_blacklist.html CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e369a23e9559
Drop "OS" modifier r=smaug,m_kato,karlt,Gijs

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e369a23e9559