Closed
Bug 1267139
Opened 8 years ago
Closed 8 years ago
Put setting pref("browser.eme.ui.enabled" together
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: JamesCheng, Assigned: JamesCheng)
Details
Attachments
(1 file)
Could it be possible to put these [1],[2] together for better readability? e.g. #if defined(MOZ_ADOBE_EME) || defined(MOZ_WIDEVINE_EME) pref("browser.eme.ui.enabled", true); #else pref("browser.eme.ui.enabled", false); #endif [1] https://dxr.mozilla.org/mozilla-central/rev/fc15477ce628599519cb0055f52cc195d640dc94/browser/app/profile/firefox.js#225 [2] https://dxr.mozilla.org/mozilla-central/rev/fc15477ce628599519cb0055f52cc195d640dc94/browser/app/profile/firefox.js#1378
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48687/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48687/
Attachment #8744811 -
Flags: review?(cpearce)
Comment 2•8 years ago
|
||
Comment on attachment 8744811 [details] MozReview Request: Bug 1267139 - Put setting pref(browser.eme.ui.enabled together. r?cpearce https://reviewboard.mozilla.org/r/48687/#review45643
Attachment #8744811 -
Flags: review?(cpearce) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f377541fc3af
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•