Closed
Bug 1267346
Opened 8 years ago
Closed 8 years ago
[PageAction] Add support for chrome.pageAction.hide on Android
Categories
(WebExtensions :: Untriaged, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: mattw, Assigned: mattw)
References
Details
(Whiteboard: [pageAction]triaged)
Attachments
(1 file)
This bug is meant to track the implementation and testing of Chrome.pageAction.hide on android. Firefox docs: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/PageAction/hide Chrome docs: https://developer.chrome.com/extensions/pageAction#method-hide Notes: We should be able to implement this method by wrapping `PageActions.hide` in the existing PageActions.jsm module.
Assignee | ||
Updated•8 years ago
|
Summary: [PageAction] Add support for chrome.pageAction.hide → [PageAction] Add support for chrome.pageAction.hide on Android
Assignee | ||
Updated•8 years ago
|
Whiteboard: triaged → [PageAction]triaged
Assignee | ||
Updated•8 years ago
|
Whiteboard: [PageAction]triaged → [pageAction]triaged
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mwein
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/52581/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/52581/
Attachment #8752389 -
Flags: review?(kmaglione+bmo)
Comment 2•8 years ago
|
||
Comment on attachment 8752389 [details] MozReview Request: Bug 1267346 - Implement chrome.PageAction.hide on Android r?kmag https://reviewboard.mozilla.org/r/52581/#review49570 ::: mobile/android/components/extensions/ext-pageAction.js:42 (Diff revision 1) > + }, > + > shutdown() { > if (this.id) { > PageActions.remove(this.id); > this.id = null; We should probably just call `this.hide()` here, now. ::: mobile/android/components/extensions/test/mochitest/test_ext_pageAction.html:30 (Diff revision 1) > - browser.test.sendMessage("page-action-shown"); > + browser.test.sendMessage("page-action-shown"); > + } else if (msg === "pageAction-hide") { > + browser.pageAction.hide(tabId); > + browser.test.sendMessage("page-action-hidden"); > + } else if (msg === "pageAction-finish") { > + browser.test.neotifyPass("page-action"); *notifyPass ::: mobile/android/components/extensions/test/mochitest/test_ext_pageAction.html:53 (Diff revision 1) > yield extension.startup(); > + yield extension.awaitMessage("ready"); > + > + extension.sendMessage("pageAction-show"); > yield extension.awaitMessage("page-action-shown"); > + is(isPageActionShown(extension.id), true, "The PageAction should be shown"); `ok(isPageActionShown(...), ...)` ::: mobile/android/components/extensions/test/mochitest/test_ext_pageAction.html:57 (Diff revision 1) > yield extension.awaitMessage("page-action-shown"); > + is(isPageActionShown(extension.id), true, "The PageAction should be shown"); > + > + extension.sendMessage("pageAction-hide"); > + yield extension.awaitMessage("page-action-hidden"); > + is(isPageActionShown(extension.id), false, "The PageAction should be hidden"); `ok(!isPageActionShown(...), ...)` ::: mobile/android/components/extensions/test/mochitest/test_ext_pageAction.html:63 (Diff revision 1) > > + extension.sendMessage("pageAction-show"); > + yield extension.awaitMessage("page-action-shown"); > is(isPageActionShown(extension.id), true, "The PageAction should be shown"); > > + extension.sendMessage("pageAction-finish"); Is this really necessary?
Attachment #8752389 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8752389 [details] MozReview Request: Bug 1267346 - Implement chrome.PageAction.hide on Android r?kmag Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52581/diff/1-2/
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b028268f4e20
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•