Closed Bug 1267578 Opened 8 years ago Closed 8 years ago

Today widget - Pressing on the 'New Private Tab' button does not always trigger the requested action on iPad Pro

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios-v4.0 --- verified
fxios-v5.0 --- fixed
fxios 4.0+ ---

People

(Reporter: csuciu, Assigned: jhugman)

References

Details

Attachments

(1 file)

Pull request
48 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review 
master 3be0655
iPad Pro 12.9" (iOS 9.3.1)

1. Add Fennec to Today view
2. Tap on 'New Private Tab'

Result: In order to open the new private tab, you'll have to tap multiple times on the button   

I was able to reproduce this issue in the simulator also
I have reproduced this issue, though haven't been able to deduce the difference between the buttons.
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
Attached file Pull request — 

        Attachment #8746008 -
        Flags: review?(sleroux)
Whiteboard: [needsuplift]

    
    

    
  
Comment on attachment 8746008 [details] [review]
Pull request

Seems to work fine for me on the simulator but I find the PR description misleading because the only thing you changed was this constraint (https://github.com/mozilla/firefox-ios/pull/1749/files#diff-1212b77cd12723ba0835407b422b084dR123) and disabling userInteractionEnabled on the subview. I'm guessing the userInteractionEnabled is what was the problem?

        Attachment #8746008 -
        Flags: review?(sleroux) → review+

    
    

    
  
Comment on attachment 8746008 [details] [review]
Pull request

Re-reviewed with the missing commit. Makes sense!

    
    

    
  
Merged and closed.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

          status-fxios-v4.0:
          affected → fixed

          status-fxios-v5.0:
          affected → fixed
Whiteboard: [needsuplift]
Target Milestone: --- → 4.0

    
    

    
  
Verifying as fixed on build 4.0.0b7

          status-fxios-v4.0:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: