Open Bug 1267869 Opened 8 years ago Updated 2 years ago

Firefox doesn't use icon (DefaultIcon) for custom protocol handlers registered via registry

Categories

(Firefox :: File Handling, defect, P3)

46 Branch
x86
All
defect

Tracking

()

People

(Reporter: firsov.f5, Unassigned)

References

Details

(Whiteboard: [CHE-BACKLOG])

Attachments

(1 file)

Attached image Capture.PNG
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.86 Safari/537.36

Steps to reproduce:

If application is registered in system as protocol handler (to handle links like mailto://blabla.bla or mysupperapp://something or even by-default-registered by Firefox FirefoxURL://something.com) Reference for custom protocol: https://msdn.microsoft.com/en-us/library/aa767914(VS.85).aspx

1. Take clean windows 7, firefox 47
2. Create simple page (locally or at http server):
<a href="FirefoxURL://google.com">Google.com</a>
3. Open page in firefox, click on link

Steps 1-3 can be performed for any other custom protocol registration, firefox still doesn't show icon in dialog.
But if you press "Select" in the dialog and select another app, Firefox will show icon for new entry.

procmon.exe utility (from sysinternals) shows that firefox.exe doesn't even read DefaultIcon registry key.


Actual results:

4. Standard firefox dialog is shown, but icon is not shown, however DefaultIcon is set:
[HKEY_CLASSES_ROOT\FirefoxURL\DefaultIcon]
@="C:\\Program Files (x86)\\Mozilla Firefox\\firefox.exe,1"

Please check attachment


Expected results:

4. Standard firefox dialog is shown, but icon IS shown
OS: Unspecified → Windows
Hardware: Unspecified → x86_64
Example for custom protocol registration:

Save next file as .reg file and run:

-------------- Begin
Windows Registry Editor Version 5.00

[HKEY_CLASSES_ROOT\note]
@="URL:Notepad app"
"URL Protocol"=""

[HKEY_CLASSES_ROOT\note\DefaultIcon]
@="\"notepad.exe,1\""

[HKEY_CLASSES_ROOT\note\shell]

[HKEY_CLASSES_ROOT\note\shell\open]

[HKEY_CLASSES_ROOT\note\shell\open\command]
@="\"notepad.exe\" \"%1\""
-------------- End

Link example: <a href="note://test">notepad</a>
Component: Untriaged → File Handling
Ivan also filed a bug for the mac OSX version of Firefox, which I could verify. So I'm changing this to all platforms.

An easy way to check this bug on mac OSX is to go to https://itunes.apple.com/nz/app/firefox-web-browser/id989804926?mt=8 and click on 'view in iTunes'.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows → All
Hardware: x86_64 → x86
Set priority to P3.

@ Wesly, may I have your help? Do we need to fix this bug on next release.
If so, please change the priority to P2 and put it on our TODO list.
Thank you.
Flags: needinfo?(wehuang)
Priority: -- → P3
Hi Ben:

Looks to me this is related the area the project is currently working on, but I'm not sure if this case will be eliminated once our project work is done. 

Maybe we should put it in our BACKLOG first? Or do you think it's MVP for us, or the other way around that not relevant to our project work at all? Thanks.
Flags: needinfo?(wehuang) → needinfo?(btian)
(In reply to Wesly Huang (Firefox EPM) from comment #5)
> but I'm not sure if this case will be eliminated once our project work is
> done. 

NO since the new flow [1] still has to show the list.
[1] https://mozilla.invisionapp.com/share/4Y6ZZH1E8#/screens/162255371

> Maybe we should put it in our BACKLOG first? Or do you think it's MVP for
> us, or the other way around that not relevant to our project work at all?
> Thanks.

I suggest it be our BACKLOG.
Flags: needinfo?(btian)
Thanks Ben, and done.
Whiteboard: [CHE-BACKLOG]
What's the current state of this?
Any progress so far?
Hi Robin, this bug is in the backlog so won't be our priority for now. Thanks!
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: