Closed
Bug 1268390
Opened 8 years ago
Closed 8 years ago
add support for doc style sheets in ServoStyleSet
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(3 files)
7.05 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
2.49 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
3.34 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b1d72ed4d65
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8746438 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8746439 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8746440 -
Flags: review?(bobbyholley)
Comment 5•8 years ago
|
||
Comment on attachment 8746438 [details] [diff] [review] Part 1: Factor out most of nsStyleSet::AddDocStyleSheet for re-use. Review of attachment 8746438 [details] [diff] [review]: ----------------------------------------------------------------- r=me modulo those fixes. ::: dom/base/nsIDocumentInlines.h @@ +51,5 @@ > + mozilla::StyleSheetHandle authorSheet = GetFirstAdditionalAuthorSheet(); > + MOZ_ASSERT(!authorSheet || > + authorSheet->IsGecko() == > + mozilla::StyleSheetHandle(aSheet)->IsGecko(), > + "why do we have a ServoStyleSheet for an nsStyleSet?"); This assertion should go, right? ::: layout/style/StyleSet.h @@ +17,5 @@ > +class StyleSet > +{ > +protected: > + template<typename T> > + static inline size_t FindDocStyleSheetInsertionPoint( This appears to live on nsIDocument on the rest of this patch. I assume you changed your mind about adding this file? We'll want it at some point, but should probably remove it for now.
Attachment #8746438 -
Flags: review?(bobbyholley) → review+
Updated•8 years ago
|
Attachment #8746439 -
Flags: review?(bobbyholley) → review+
Updated•8 years ago
|
Attachment #8746440 -
Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/750e7e90045e https://hg.mozilla.org/integration/mozilla-inbound/rev/172901ec8248 https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c78dedb9c9
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/750e7e90045e https://hg.mozilla.org/mozilla-central/rev/172901ec8248 https://hg.mozilla.org/mozilla-central/rev/f5c78dedb9c9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•