1268903 - Make autoland rebase revision configurable

Status: RESOLVED WONTFIX

(Conduit Graveyard :: Transplant, defect, P3)

Description

[Gregory Szorc [:gps]]

Currently, Autoland rebased onto 'tip' from the destination repo. This needs to be configurable so e.g. we can specify alternate branches or bookmarks to autoland to.

Comment 1

[Dan Minor [:dminor]]

Rough outline of the work required for this:
1) Add a new field for the rebase revision to the custom hosting service at [1].
2) Retrieve the data at [2] and pass it to autoland at [3].
3) Retrieve the value in autoland at [4] and pass it into the transplant function at [5].
4) Use the value when rebasing at [6].


[1] https://dxr.mozilla.org/hgcustom_version-control-tools/source/pylib/mozreview/mozreview/hostingservice/hmo_repository.py
[2] https://dxr.mozilla.org/hgcustom_version-control-tools/source/pylib/mozreview/mozreview/autoland/resources.py#154
[3] https://dxr.mozilla.org/hgcustom_version-control-tools/source/pylib/mozreview/mozreview/autoland/resources.py#194
[4] https://dxr.mozilla.org/hgcustom_version-control-tools/source/autoland/autoland/autoland.py#94
[5] https://dxr.mozilla.org/hgcustom_version-control-tools/source/autoland/autoland/autoland.py#117
[6] https://dxr.mozilla.org/hgcustom_version-control-tools/source/autoland/autoland/transplant.py#56

Comment 2

[Justin Wood (:Callek)]

:mcote, is this wontfix with the phabricator plan?

Comment 3

[:glob ✱]

no, phabricator still uses autoland-transplant.

Comment 4

[:glob ✱]

No longer required.