1269161 - Remove the separate worker bindings for URL

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We'll probably need to introduce some sort of abstract base class here.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: url.patch

Comment 2

[(no longer active)]

I started reviewing this today but ran out of time.  The patch is very large and it contains a lot of things that look like just moving the code around.  Can you please indicate what things have moved without changing and what things have actually changed?  That should help simplify reviewing this.

(Also sorry for the delay, I'm trying hard to finish reviewing it this week!)

Comment 3

[Andrea Marchesini [:baku]]

What this patch does is:

1. It creates a base class for URL (dom/base/URL.h)

2. in dom/base/URL.cpp we have 2 implementations of the base class: URLMainThread and URLWorker.
URLMainThread is the old URL class. Code is moved around. Plus assertions about main-thread only execution.

3. URLWorker is a new class (inheriting URL base class) that is the old dom/worker/URL.cpp code moved here.

Before, in workers, the setup was based on a proxy. There was a URLProxy object that was creating a URL object on the main-thread and then, any getter and setter call was sent to that main-thread object.

Now we have the same proxy that creates a URLMainThread object.

Comment 4

[Andrea Marchesini [:baku]]

:ehsan, ping?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8748637 [details] [diff] [review]
url.patch

Review of attachment 8748637 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/URL.webidl
@@ +28,1 @@
>    attribute USVString href;

If the SetterThrows, and the GetterThrows, then just Throws?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81c91e482d44
Remove the separate worker bindings for URL, r=khuey

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81c91e482d44

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

as  a note this reduced the num_constructors reported from the build:
https://treeherder.mozilla.org/perf.html#/alerts?id=1626