1269304 - IRC notifications for travis

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Martin Thomson [:mt:]]

Attachment: Add IRC, fix ordering.

Not 100% that this works, but it seems right and can be tested when it lands.

Comment 1

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8747644 [details] [diff] [review]
Add IRC, fix ordering.

Review of attachment 8747644 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, but please no windows line endings.

The only question is if we want to have this in #nss or in #nssbot, which already has the buildbot status updates. I think I'd prefer #nssbot.

Comment 2

[Martin Thomson [:mt:]]

Attachment: bug1269304.patch

OK, line endings fixed and name changed.

Comment 3

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8748015 [details] [diff] [review]
bug1269304.patch

Review of attachment 8748015 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, but I'm not sure if this has to be in the notifications section, see https://docs.travis-ci.com/user/notifications/#IRC-notification.
Playing around with it this worked for me (I haven't seen any notifications yet, but there were no failures):
notifications:
  irc:
    channels:
      - "irc.mozilla.org:6697/#nssbot"
    nick: travisci-franziskus
    on_success: change
    on_failure: always
Maybe just go ahead and land something then we see how it works.

Comment 4

[Martin Thomson [:mt:]]

Comment on attachment 8748015 [details] [diff] [review]
bug1269304.patch

https://hg.mozilla.org/projects/nss/rev/04835efdd1b6 - with the notifications section added.

Comment 5

[Martin Thomson [:mt:]]

Messed up the IRC config apparently. https://hg.mozilla.org/projects/nss/rev/b3981e62834c