Closed
Bug 1269349
Opened 8 years ago
Closed 8 years ago
make robocop honor --timeout
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
2.21 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
Our testsuites normally disable timeouts when --debugger or similar options are specified. Robocop doesn't do this, because apparently the best way to debug Robocop tests is to |mach robocop [TEST-NAMES...]|, wait for the browser window to show, and then connect a debugger. This setup seems suboptimal. The setup being what it is, though, implies that runrobocop.py has no knowledge of a debugger being connected, and therefore no idea that the test really shouldn't time out. Which then leads to the test going away at that crucial moment when you are this > < close to figuring out the bug. Let's make runrobocop.py understand that --timeout means something useful for such a context.
Assignee | ||
Comment 1•8 years ago
|
||
snorp told me the setup in comment 0 is how one debugs robocop tests, so there might be a better way. This patch seems helpful in any event.
Attachment #8747711 -
Flags: review?(gbrown)
Updated•8 years ago
|
Attachment #8747711 -
Flags: review?(gbrown) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e8271e245c36
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•