1269349 - make robocop honor --timeout

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Nathan Froyd [:froydnj]]

Our testsuites normally disable timeouts when --debugger or similar
options are specified.  Robocop doesn't do this, because apparently the
best way to debug Robocop tests is to |mach robocop [TEST-NAMES...]|,
wait for the browser window to show, and then connect a debugger.  This
setup seems suboptimal.

The setup being what it is, though, implies that runrobocop.py has no
knowledge of a debugger being connected, and therefore no idea that the
test really shouldn't time out.  Which then leads to the test going away
at that crucial moment when you are this > < close to figuring out the
bug.  Let's make runrobocop.py understand that --timeout means something
useful for such a context.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make robocop honor --timeout

snorp told me the setup in comment 0 is how one debugs robocop tests, so there
might be a better way.  This patch seems helpful in any event.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8271e245c36

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e8271e245c36