126937 - PR_GetSysfdTableMax incorrectly implemented on OS/2, PR_SetSysfdTableSize not implemented

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Julien Pierre]

On OS/2 this function assumes there is a max of 16K file handles open in the system.

The OS/2 control program doc says the maximum default is 50 for a process.
It can be queried with
APIRET rc = DosSetRelMaxFH(PLONG pcbReqCount, PULONG pcb CurMaxFH);

pcbReqCount is the signed number to be added or subtracted to the current max
file handle count for the process. Use 0 to query.
PULONG is a pointer to a ULONG where the current max for the process is returned.

The max can also be set in an absolute manner using 
APIRET rc = DosSetMaxFH(ULONG count);

Comment 1

[Julien Pierre]

FYI this is in mozilla/nsprpub/pr/src/io/prfile.c

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Fix

Here's an implementation of PR_GetSysfdTableMax and PR_SetSysfdTableSize for
OS/2

Comment 3

[jhp (no longer active)]

Comment on attachment 116430 [details] [diff] [review]
Fix

Dude, you are returning NO_ERROR on success rather than the number of file
handles.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: The right fix :)

I shouldn't even be checking RC. This API actually can't fail.

Comment 5

[Mike Kaply [:mkaply]]

wtc, could you please check this into NSPR?

Thanks

Comment 6

[Wan-Teh Chang]

Patch checked into the NSPR trunk (NSPR 4.4.1) and
NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.5a).