1269934 - Handle visible frame sets more generically in PresShell

Status: REOPENED

(Core :: Layout, defect)

Description

[Seth Fowler [:seth] [:s2h]]

As we add more notions of frame visibility it becomes more important that the frame visibility-related code handles the different visibility counters generically whenever possible. This minimizes the amount of code we have to update when a new visibility counter is introduced. Let's get this done before things get complicated further.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Handle visible frame sets more generically in PresShell.

Here's the patch. All this does is try to use VisibilityCounters where possible
instead of hardcoding specific types of frame visibility.

Comment 2

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4517cddd204ee56e5ef8ca9dbd7aed6efe911895
Bug 1269934 - Handle visible frame sets more generically in PresShell. r=mstange

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4517cddd204e

Comment 4

[Timothy Nikkel (:tnikkel)]

I backed this bug out on inbound, I expect the backout to get merged to mozilla-central. I plan to also request uplift to backout on aurora (so this bug would not be landed in any version of Firefox).

Bug 1284350 tracks the back out.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.