1269935 - Replace PresShell::DecVisibleCount() with a general map function

Status: REOPENED

(Core :: Layout, defect)

Description

[Seth Fowler [:seth] [:s2h]]

PresShell::DecVisibleCount() just iterates over all the frames in a visible frames set and decrements a counter for each one for which visibility tracking is still enabled. We'll soon need to add more code that does this kind of iteration, so it makes sense to replace DecVisibleCount() with a general iterator function that takes a lambda as an argument.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Replace PresShell::DecVisibleCount() with a general map function.

Here's the patch. We'll be making use of this map function a good deal in
upcoming patches.

Comment 2

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45c3308d49c95e37c8d1e4855231baa976a7fe9a
Bug 1269935 - Replace PresShell::DecVisibleCount() with a general map function. r=mstange

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45c3308d49c9

Comment 4

[Timothy Nikkel (:tnikkel)]

I backed this bug out on inbound, I expect the backout to get merged to mozilla-central. I plan to also request uplift to backout on aurora (so this bug would not be landed in any version of Firefox).

Bug 1284350 tracks the back out.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.