1270853 - Remove HTML5 video controls statistics

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

I've heard reports from some of the developers who work on video playback for Gecko, as well as Dolske, that the statistics offered through the controls are unreliable/don't offer enough data to make them useful.

Instead of iterating on them right now it would be better to remove them. If we come across some new needs or different ideas of integrating them than we can pursue those at that time.

Comment 1

[sworddragon2]

Does keeping them interfere something? Otherwise I see no reason to remove them. Also besides Firefox developers these statistics could be useful for normal users and web developers.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Chris, do you have a response in regards to comment #1?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v1.1

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

I don't feel strongly about keeping the default video controls' playback stats; I certainly don't find they add much value.

We could rework them to be based on VideoPlaybackQuality.

Anthony has interest in video playback perf reporting/statistics. He may have an opinion here. We've been discussing how Gecko can provide more useful statistics to web devs. Once we've figured out a path there, we could add those new stats to the default video controls.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8749788 [details] [diff] [review]
Patch v1.1

From a quick look this looks more or less OK, but it seems like we should also be removing:

https://dxr.mozilla.org/mozilla-central/rev/e5a10bc7dac4ee2453d8319165c1f6578203eac7/browser/base/content/content.js#721-727

In any case, we do also need consensus that removal is what we want to do here.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Dolske, where do you stand with removing the current implementation of the statistics until we have the reworked ones described in comment #4?

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

I'm OK with just removing them. I don't think they're useful to a lot of people. Displaying video playback stats is a pretty advanced use case.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for check-in

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

I'll clear the needinfo and mark this as checkin-needed based on this bug being added as blocking bug 1271768.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for check-in (rebased)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing (sorry :\)

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for check-in (rebased 2)

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0d17446ad21a

Comment 14

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/0ba8107314d6e579f881399cc2ec0a6478080a90 (probably unnecessarily) while backing out bug 1181055

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/83a1b9c7ae8d

Comment 16

[Ryan VanderMeulen [:RyanVM]]

This was the guilty party, not bug 1181055.

Comment 17

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/ebd649229181

Comment 18

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/976f7eede8229530b737f1ca7eb151a502b46bd3
Bug 1270853 - Remove HTML5 video controls statistics. r=gijs, r=bz for removing internal chrome/xbl attribute in webidl

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/976f7eede822

Comment 20

[Jean-Yves Avenard [:jya]]

well, I certainly it was still there right now, as is it's the available option to display stats in full screen mode.

can we add it back?

Comment 21

[Jean-Yves Avenard [:jya]]

missing wish in that above sentence :)