Closed
Bug 1270886
Opened 8 years ago
Closed 8 years ago
Search bar shouldn't get lightweight theme treatment when placed in the menu panel
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: dao, Assigned: Gijs)
References
Details
Attachments
(1 file)
This change from bug 1270148: -#nav-bar:-moz-lwtheme { +#main-window:-moz-lwtheme { --urlbar-border-color: rgba(0,0,0,.3); } ... is wrong. The search bar's border color should only change for lightweight themes when the search bar is in a context where lightweight themes matter -- i.e. not in the menu panel.
Reporter | ||
Updated•8 years ago
|
Version: 48 Branch → Trunk
Assignee | ||
Comment 1•8 years ago
|
||
This is still not completely perfect in that in principle it is possible for add-ons to add toolbars that they force to be non-transparent, but there is no way to select for that. Keeping a list of toolbars we know are transparent would break the more common case of third-party toolbars that do behave 'normally' when used with lightweight themes. So for now, just assume navigator-toolbox is all transparent when a lwtheme is in use. Review commit: https://reviewboard.mozilla.org/r/51365/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51365/
Attachment #8750349 -
Flags: review?(dao+bmo)
Reporter | ||
Updated•8 years ago
|
Attachment #8750349 -
Flags: review?(dao+bmo) → review+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4dd60a8b9e2b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in
before you can comment on or make changes to this bug.
Description
•