1271075 - [e10s] New tab position on middle click

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ivailo Stoianov]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160507004025

Steps to reproduce:

1. Open a new blank tab.
2. Middle click on a pinned site.


Actual results:

The tab was opened at the end of my tab list.


Expected results:

The tab should've been opened after the current blank tab.

Comment 1

[YF (Yang)]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=385840329d91&tochange=26d6392b5403

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 3

[Alice0775 White]

This is e10s specific problem.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Regression in 48, tracking.

Comment 5

[Tracy Walker [:tracy]]

Middle clicking a tab closes that tab.

Ivailo, are you using an add-on that changes that behavior?

Comment 6

[Ivailo Stoianov]

(In reply to Tracy Walker [:tracy] from comment #5)
> Middle clicking a tab closes that tab.
> 
> Ivailo, are you using an add-on that changes that behavior?

I meant a middle click on a pinned site in the New Tab page(https://support.mozilla.org/en-US/kb/about-tiles-new-tab). Can confirm it's a e10s problem. Once disabled the bug is gone as well.

Comment 7

[Tracy Walker [:tracy]]

Ah, yes.  I can reproduce that and confirm it is happening only in e10s mode.  A bit clear STR's as follows:

1) open New Tab page
2) Pin one of the available pages offered
3) Open a few pages in their own tabs
4) go back to the New Tab page of step 1.
5) Middle click the option you pinned in step 2

Actual results:

The tab was opened at the end of the tab list. (happens in e10s only)

Expected results:

The tab should've been opened after the current blank tab. (works as expected in non-e10s)

Comment 8

[Barbara Bermes [:barbara] - NI please!]

Does this only happen on Windows?

Comment 9

[Tracy Walker [:tracy]]

(In reply to Barbara Bermes [:barbara] from comment #8)
> Does this only happen on Windows?

It is reproducible on all platforms.

Comment 10

[Barbara Bermes [:barbara] - NI please!]

It's not blocking but should be something to be worked on soon, i.e P1, it's an expected behaviour that the user is currently not getting and might be frustrating for people who have a lot of tabs open.

Comment 11

[Justin Dolske [:Dolske]]

Tim, is there someone on the newtab team(?) who can look into this?

Comment 12

[Tim Spurway [:tspurway]]

:emtwo is taking a look at this

Comment 13

[Marina Samuel [:emtwo]]

Attachment: v1: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'.

Comment 14

[Marina Samuel [:emtwo]]

Waiting on bug 1283332 to run this on try server, but tests pass locally.

Comment 15

[Marina Samuel [:emtwo]]

Comment on attachment 8766598 [details] [diff] [review]
v1: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c0170bee84b59d60aa176a87c5c4a713381b1b5

Mostly done on try and looking good.

Comment 16

[Marina Samuel [:emtwo]]

https://hg.mozilla.org/integration/fx-team/rev/e3d304afd3f2bb3301374a37486f48174a367c27
Bug 1271075: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'. r=ursulasarracini

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e3d304afd3f2

Comment 18

[Gerry Chang [:gchang]]

Hi Marina, do you want to uplift this for 48/49 if this patch is not too risky?

Comment 19

[Marina Samuel [:emtwo]]

Hi Gerry, I do believe this patch isn't too risky and it sounds like something that could be frustrating to users so I do support uplifting it.

Comment 20

[Marina Samuel [:emtwo]]

Comment on attachment 8766598 [details] [diff] [review]
v1: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'.

Approval Request Comment

[Feature/regressing bug #]: Bug 1054221 

[User impact if declined]: Middle click on newtab links opens a tab at the end of the tab list but it should open right next to the newtab page. This may be a frustration to many users who use this functionality often.

[Describe test coverage new/current, TreeHerder]: New tests added. Existing tests pass on try, fx-team, and m-c

[Risks and why]: Not much risk. It's a 1-liner with passing tests.

[String/UUID change made/needed]: n/a

Comment 21

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8766598 [details] [diff] [review]
v1: Sites on the new tab page opened with middle click in e10s should have a 'referrerURI'.

Has a new test, seems good to fix this e10s issue for early rollout in 48.

Comment 22

[Liz Henry (:lizzard) (relman/hg->git project)]

We should verify this fix once it lands on beta. 
If it causes any regressions, let's think about backing it out immediately, at least from beta.

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c544c41ae8f

Comment 24

[Carsten Book [:Tomcat]]

 https://hg.mozilla.org/releases/mozilla-beta/rev/d142c49033c0

Comment 25

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this bug using Fx 49.0a1 build ID:20160507030302 , on Windows 10 x64.
Confirmed the fix on Fx 48.0b6, build ID  20160706215822; Fx 49.0a2, build ID  20160707004018;  and Fx 50.0a1, build ID 20160701030235 on Windows 10 x64, Mac OS X 10.11.1 and Ubuntu 14.04 LTS.