1271395 - Help submenu fixes (in Hamburger menu)

Status: NEW

(Firefox :: Menus, defect)

Description

[Sevaan Franks [:sevaan]]

Attachment: Help Submenu

If we slightly tweak the margins in the Help submenu in the Hamburger menu, we will be able to fit the last character in "Restart with Add-ons Disabled".

Also, we should remove the elipses from "Submit Feedback" and "Report Deceptive Site" for consistency with the other menu items.

Comment 1

[Justin Dolske [:Dolske]]

"Restart without Add-ons"?

Also, I believe the intent of the "…" is to indicate further user interaction is needed to complete a command, so these seem correct?

Comment 2

[Sevaan Franks [:sevaan]]

"Restart without Add-ons" works great and solves the margins issue.

I'm still not sold on the ellipses as an indication of further user interaction as I'm not sure that it's necessary. The text itself sort of implies some user interaction after.

Matej, what do you think?

Comment 3

[Matej Novak [:matej]]

(In reply to Sevaan Franks [:sevaan] from comment #2)
> "Restart without Add-ons" works great and solves the margins issue.
> 
> I'm still not sold on the ellipses as an indication of further user
> interaction as I'm not sure that it's necessary. The text itself sort of
> implies some user interaction after.
> 
> Matej, what do you think?

I'm actually to flag Michelle here for a call on this.

Comment 4

[mheubusch]

So, the last version that I have of the Firefox style guide indicates we *should* use ellipses to indicate further user action required.  "Use ellipses with Button or Menu items when the action will require further user input (this usually results in either a Dialog, Alert or moving the operation to another window or part of the UI); do not use in a link to indicate that there is more information available at the destination (this should be assumed)".
So for now, let's keep the ellipses.


Matej, I agree that it is not entirely necessary, so if we opt to not use it here, we should update the style guide and make this change to the products globally.  The style for another browser you may have heard of rules that "Omit ellipses from menu items or buttons that open a dialog or start some other process." I will follow up separate with Madhava and/or you to find out where the style guide current lives and who has been maintaining it since I delivered it in March, and we can go from there.

Comment 5

[Matej Novak [:matej]]

Sounds great. Thanks Michelle.

Sevaan, does that give you what you need?

Comment 6

[Sevaan Franks [:sevaan]]

(In reply to mheubusch from comment #4)
> So for now, let's keep the ellipses.

Yes, thanks all!