1271594 - Tab.loadFavicon(): On failure discard explicit URL instead of first one

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Tab.java: If loading a favicon failed we discard its URL from the list of available favicons.

However we are always discarding the first one:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/Tab.java#463

While this favicon URL was the first one when we initiated the load, it doesn't need to be the first one after the load has failed. In fact when starting the load we even assume that the one we load might not be the first one (anymore):
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/Tab.java#431-445

We should explicitly discard the URL we just tried to load.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Not yet

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.