Closed
Bug 1271636
Opened 8 years ago
Closed 8 years ago
Correct error message in GeckoDriver#setWindowSize
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(1 file)
The error message is misleading. Clarify language.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51627/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51627/
Attachment #8750791 -
Flags: review?(dburns)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8750791 [details] MozReview Request: Bug 1271636 - Clarify language in error for GeckoDriver#setWindowSize; r?automatedtester https://reviewboard.mozilla.org/r/51627/#review48519
Attachment #8750791 -
Flags: review?(dburns) → review+
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ato
Keywords: ateam-marionette-server
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8750791 [details] MozReview Request: Bug 1271636 - Clarify language in error for GeckoDriver#setWindowSize; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51627/diff/1-2/
Had to back this out because it upset Mn tests on Windows: https://hg.mozilla.org/integration/mozilla-inbound/rev/213ee4335c5d https://treeherder.mozilla.org/logviewer.html#?job_id=27684448&repo=mozilla-inbound
Flags: needinfo?(ato)
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
Flags: needinfo?(ato)
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8750791 [details] MozReview Request: Bug 1271636 - Clarify language in error for GeckoDriver#setWindowSize; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51627/diff/2-3/
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c901fbc06bf0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
|
|
||
Comment 9•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/023770b1ecf1
status-firefox48:
--- → fixed
|
|
||
Comment 10•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/023770b1ecf1
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•