1272110 - Permission denied when trying to exec /etc/taskcluster-interactive-shell.sh

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Andrew Halberstadt [:ahal]]

If an image has a /etc/taskcluster-interactive-shell.sh file, when running an interactive shell, that file should be run instead of bash:
https://github.com/taskcluster/taskcluster-tools/blob/master/shell/app.jsx#L37

However, I'm getting "Permission denied" here (after the motd prints correctly). To reproduce, you can spin up a loaner based on this task and start the shell:
https://tools.taskcluster.net/task-inspector/#XGssLQNBSUqF4WwKa5oyAg/0

I was able to get this working by setting up a local copy of taskcluster-tools and instead reading the start script from $HOME/taskcluster-interactive-shell.sh. Alternatively we should make sure the file has the proper permissions set.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Run taskcluster-interactive-shell.sh from $HOME

I vaguely remember that we needed to run everything as root before, and then Dustin or someone changed that. Maybe this used to work back then?

I tested this patch with a local instance of taskcluster-tools and it wfm.

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: github counter offer

Will this do?

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8753844 [details] [review]
Run taskcluster-interactive-shell.sh from $HOME

I don't like the $HOME variable... that seems a bit unpredictable to me.
Let's do an absolute path, so there is no confusion. You can still change user inside the script if you want.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8754108 [details] [review]
github counter offer

Yep, wfm! I like this better too.

Comment 5

[Andrew Halberstadt [:ahal]]

https://github.com/taskcluster/taskcluster-tools/commit/5e25304022ba618256e55d80aec3135cd0adc1b8