Closed
Bug 1272320
Opened 8 years ago
Closed 8 years ago
Convert NS_ImplementChannelOpen to support asyncOpen2()
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
|
2.03 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Hey Pat, to be on the safe side we should only call asyncOpen2() if we actually provide the right security arguments, otherwise we should continue to call asyncOpen(). We have such 'if' checks elsewhere in the code. We will clean that up once we deprecate asyncOpen. Sounds good?
Attachment #8751741 -
Flags: review?(mcmanus)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8751741 [details] [diff] [review] bug_1272320_implementchannelopen_support_asyncopen2.patch Review of attachment 8751741 [details] [diff] [review]: ----------------------------------------------------------------- sgtm
Attachment #8751741 -
Flags: review?(mcmanus) → review+
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a079a7f391a3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•