Closed
Bug 1272431
Opened 8 years ago
Closed 8 years ago
Make TelemetryPingStore.getAllPings return pings in order – earliest to latest
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Firefox 49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(3 files)
| Comment hidden (typo) |
|
Assignee | |
Comment 1•8 years ago
|
||
via bug 1270213 comment 24. This lets us try to offload our data before it gets deleted if we run out of space to store pings.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53036/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53036/
Attachment #8753144 -
Flags: review?(s.kaspari)
Attachment #8753145 -
Flags: review?(s.kaspari)
Attachment #8753146 -
Flags: review?(s.kaspari)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53038/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53038/
|
|
Assignee | |
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53040/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53040/
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8753144 [details] MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53036/diff/1-2/
Attachment #8753144 -
Attachment description: MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=sebastian → MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=ahunt
Attachment #8753145 -
Attachment description: MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=sebastian → MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=ahunt
Attachment #8753146 -
Attachment description: MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=sebastian → MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=ahunt
Attachment #8753144 -
Flags: review?(s.kaspari) → review?(ahunt)
Attachment #8753145 -
Flags: review?(s.kaspari) → review?(ahunt)
Attachment #8753146 -
Flags: review?(s.kaspari) → review?(ahunt)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8753145 [details] MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53038/diff/1-2/
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8753146 [details] MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53040/diff/1-2/
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8753144 [details] MozReview Request: Bug 1272431 - Correct order errors in maybePrunePings tests. r=ahunt https://reviewboard.mozilla.org/r/53036/#review50382
Attachment #8753144 -
Flags: review?(ahunt) → review+
|
|
||
Comment 10•8 years ago
|
||
Comment on attachment 8753145 [details] MozReview Request: Bug 1272431 - Return pings from getAllPings in guaranteed order. r=ahunt https://reviewboard.mozilla.org/r/53038/#review50386
Attachment #8753145 -
Flags: review?(ahunt) → review+
|
|
||
Updated•8 years ago
|
Attachment #8753146 -
Flags: review?(ahunt) → review+
|
|
||
Comment 11•8 years ago
|
||
Comment on attachment 8753146 [details] MozReview Request: Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=ahunt https://reviewboard.mozilla.org/r/53040/#review50406
|
|
Assignee | |
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/318ef7e93e40e8baf65d9517adfdb545baa66e72 Bug 1272431 - Correct order errors in maybePrunePings tests. r=ahunt https://hg.mozilla.org/integration/fx-team/rev/aba775e7b89cc0e334603aec5e54c6a64ded2d83 Bug 1272431 - Return pings from getAllPings in guaranteed order. r=ahunt https://hg.mozilla.org/integration/fx-team/rev/536b16b34e0f0132322cb82f0e0a1554877bbdc0 Bug 1272431 - Do not use API 19+ method for FileLastModifiedComparator. r=ahunt
|
||
Comment 13•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/318ef7e93e40 https://hg.mozilla.org/mozilla-central/rev/aba775e7b89c https://hg.mozilla.org/mozilla-central/rev/536b16b34e0f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.