1272554 - Add lambda versions of nsIDocument::EnumerateSubDocuments

Status: NEW

(Core :: DOM: Core & HTML, defect)

Description

[Seth Fowler [:seth] [:s2h]]

It'd be extremely natural for nsIDocument::EnumerateSubDocuments() to take a lambda function, so let's add a version that does so. (Given that EnumerateSubDocuments() is virtual and the lambda version should be a template, we actually need to add a different method that calls the original.)

While we're at it, it's a common need to apply the same function to both a document and all of its subdocuments. This is especially convenient when using lambdas. Let's add another variant of EnumerateSubDocuments() for that purpose, too.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Add lambda versions of nsIDocument::EnumerateSubDocuments().

Here's the patch. The new methods use a local captureless lambda to create a
normal function pointer which can be passed to EnumerateSubDocuments(), so the
original implementation is used under the hood.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: Add lambda versions of nsIDocument::EnumerateSubDocuments().

Argh, noticed a comment typo immediately after uploading.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8752039 [details] [diff] [review]
Add lambda versions of nsIDocument::EnumerateSubDocuments().

Review of attachment 8752039 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsIDocument.h
@@ +1553,5 @@
>     */
>    typedef bool (*nsSubDocEnumFunc)(nsIDocument *aDocument, void *aData);
>    virtual void EnumerateSubDocuments(nsSubDocEnumFunc aCallback,
>                                       void *aData) = 0;
> +  /**

Nit: add a blank line before the beginning of this comment.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.