Closed
Bug 1272692
Opened 8 years ago
Closed 8 years ago
Update Bing to new icon
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
VERIFIED
FIXED
Firefox 50
People
(Reporter: mkaply, Assigned: mkaply)
References
Details
(Whiteboard: [partner search] [fxsearch])
Attachments
(1 file, 1 obsolete file)
11.05 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
We updated Bing to the new icon for mobile here: https://bugzilla.mozilla.org/show_bug.cgi?id=1246988 We need to do the same for Desktop.
Comment 1•8 years ago
|
||
Do we need this for a specific release, or can this just ride the trains?
Flags: needinfo?(mozilla)
Assignee | ||
Comment 3•8 years ago
|
||
Anthony, Any chance you could provide a 32x32 icon similar to what you did in bug 1246988? I was able to get 16x16 from http://www.bing.com/favicon.ico Thanks!
Flags: needinfo?(alam)
Updated•8 years ago
|
Whiteboard: [partner search] [fxsearch]
Comment 4•8 years ago
|
||
I'm going to toss this over to Shorlander for the Desktop side of things :)
Flags: needinfo?(alam) → needinfo?(shorlander)
Comment 5•8 years ago
|
||
There is a 32 x 32 icon here: https://www.bing.com/sa/simg/bing_p_rr_teal_min.ico
Flags: needinfo?(shorlander)
Assignee | ||
Comment 6•8 years ago
|
||
That's what I needed. I'll take care of the code side. I looked and couldn't find one.
Assignee | ||
Comment 7•8 years ago
|
||
data:image/x-icon;base64,AAABAAIAICAAAAEAIACoEAAAJgAAABAQAAABACAAaAQAAM4QAAAoAAAAIAAAAEAAAAABACAAAAAAAIAQAAAAAAAAAAAAAAAAAAAAAAAAhIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4+PI/+1tW7/ycmT/5eXMf+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+oqFP/3t6+////////////7OzZ/76+f/+PjyP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+fn0H/0tKl//n58////////////////////////////97evv+oqFP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/j48j/+XlzP////////////////////////////////////////////n58//S0qX/n59B/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+PjyP/7OzZ///////////////////////////////////////////////////////s7Nn/ycmT/4+PI/+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4+PI//s7Nn/////////////////////////////////////////////////////////////////7OzZ/7W1bv+PjyP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/j48j/+zs2f/////////////////y8uX/vr5//97evv///////////////////////////////////////////97evv+oqFP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+PjyP/7OzZ/////////////////+zs2f+PjyP/j48j/76+f//s7Nn///////////////////////////////////////Ly5f/JyZP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4+PI//s7Nn/////////////////8vLl/4+PI/+EhAz/hIQM/5eXMf/JyZP/8vLl/////////////////////////////////+zs2f+PjyP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/j48j/+zs2f/////////////////y8uX/j48j/4SEDP+EhAz/hIQM/4SEDP+oqFP/3t6+////////////////////////////7OzZ/4+PI/+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+PjyP/7OzZ//////////////////Ly5f+PjyP/hIQM/4SEDP+EhAz/hIQM/4+PI/++vn//8vLl///////////////////////s7Nn/j48j/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4+PI//s7Nn/////////////////8vLl/4+PI/+EhAz/hIQM/4+PI/++vn//7OzZ/////////////////////////////////+zs2f+PjyP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/j48j/+zs2f/////////////////y8uX/j48j/4SEDP+EhAz/vr5/////////////////////////////////////////////7OzZ/4+PI/+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+PjyP/7OzZ//////////////////Ly5f+PjyP/hIQM/4+PI//e3r7//////////////////////////////////////+zs2f++vn//hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4+PI//s7Nn/////////////////8vLl/4+PI/+EhAz/qKhT//n58///////////////////////7OzZ/8nJk/+oqFP/j48j/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/j48j/+zs2f/////////////////y8uX/j48j/4SEDP/S0qX////////////s7Nn/0tKl/7W1bv+PjyP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+PjyP/7OzZ//////////////////Ly5f+PjyP/l5cx/97evv/Y2LL/tbVu/5eXMf+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4+PI//s7Nn/////////////////8vLl/4+PI/+PjyP/l5cx/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/j48j/+zs2f/////////////////y8uX/j48j/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+PjyP/7OzZ//////////////////Ly5f+PjyP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4+PI//s7Nn/////////////////8vLl/4+PI/+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/j48j/+zs2f/////////////////y8uX/j48j/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+PjyP/7OzZ//////////////////Ly5f+PjyP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4+PI//s7Nn/////////////////7OzZ/4+PI/+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/j48j/+zs2f//////7OzZ/8nJk/+oqFP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+PjyP/vr5//66uX/+PjyP/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/4SEDP+EhAz/hIQM/wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKAAAABAAAAAgAAAAAQAgAAAAAABABAAAAAAAAAAAAAAAAAAAAAAAAISEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/5mZKP+ZmSj/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/kpIW/76+e//w8OH/8PDh/8bGiv+Skhb/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/76+e///////////////////////8PDh/76+e/+Skhb/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP++vnv///////n58v/g4MH/////////////////4ODB/6qqUf+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/vr57///////w8OH/mZko/7KyYv/o6M//////////////////srJi/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/76+e///////8PDh/5KSFv+EhAD/mZko/+Dgwf///////////76+e/+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP++vnv///////Dw4f+Skhb/kpIW/+Dgwf////////////////++vnv/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/vr57///////w8OH/kpIW/76+e////////////+joz//Gxor/kpIW/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/76+e///////8PDh/5mZKP/U1Kj/zc2Z/6qqUf+Skhb/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP++vnv///////Dw4f+Skhb/kpIW/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/vr57///////w8OH/kpIW/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/76+e///////8PDh/5KSFv+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP++vnv/8PDh/83Nmf+MjAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/kpIW/5mZKP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP+EhAD/hIQA/4SEAP8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
Updated•8 years ago
|
Assignee: nobody → mozilla
Assignee | ||
Comment 8•8 years ago
|
||
Marking for review from Florian. Feedbacking Joanne as an FYI.
Attachment #8769259 -
Flags: review?(florian)
Attachment #8769259 -
Flags: feedback?(jnagel)
Comment 9•8 years ago
|
||
(In reply to Mike Kaply [:mkaply] from comment #8) > Created attachment 8769259 [details] [diff] [review] > Update icon > > Marking for review from Florian. Why is this new icon file (5430 bytes) larger than the previous one (3732)? Is there any way to optimize it? If I extract the 2 images it contains, they are both < 1kB, and can still be shrunk a little bit with eg. pngcrush
Flags: needinfo?(mozilla)
Assignee | ||
Comment 10•8 years ago
|
||
I had used the icon in google.xml as the basis for my new icon which is 32bpp (didn't realize it at the time). The original bing icon is 8bpp and I've siwtched to that.
Attachment #8769259 -
Attachment is obsolete: true
Attachment #8769259 -
Flags: review?(florian)
Attachment #8769259 -
Flags: feedback?(jnagel)
Flags: needinfo?(mozilla)
Attachment #8769746 -
Flags: review?(florian)
Comment 11•8 years ago
|
||
Comment on attachment 8769746 [details] [diff] [review] Use 8 bit icon Review of attachment 8769746 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the spaces between "<Image width="16" height="16">" and "data:" removed.
Attachment #8769746 -
Flags: review?(florian) → review+
Assignee | ||
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2e5b22652d834a59b920901b806c35c7943e678c Bug 1272692 - New Bing icon. r=florian
Assignee | ||
Comment 13•8 years ago
|
||
And of course I removed the spaces and then forgot to save and pushed. Argh. I'll repush as notpart of build
Assignee | ||
Comment 14•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5978434c7789519778ba9f46ec723f06363a7a65 Bug 1272692 - New Bing icon - remove unnecessary spaces. r=florian DONTBUILD
Assignee | ||
Comment 15•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/dbe1d746fdff01e041486a83734a1cb677d4e474 Bug 1272692 - New Bing icon (Update test). r=florian
Assignee | ||
Comment 16•8 years ago
|
||
The test references the icon data and I completely missed that. Should have ran the browser tests.
Comment 17•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2e5b22652d83 https://hg.mozilla.org/mozilla-central/rev/5978434c7789 https://hg.mozilla.org/mozilla-central/rev/dbe1d746fdff
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 18•8 years ago
|
||
I have reproduced this bug with Firefox nightly 49.0a1 (2016-05-13) on Windows 10, 64 Bit. The Bug's fix is now verified on latest nightly 50.0a1 Build ID 20160713030216 User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0 [bugday-20160713]
Comment 19•8 years ago
|
||
I have reproduced this bug on Nightly 49.0a1 (2016-05-13) (Build ID: 20160513030539) on Linux, 64 bit! The bug's fix is now verified on Latest Nightly 50.0a1! Build ID: 20160713030216 User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0 OS: Ubuntu 16.04, Linux 4.4.0-28-generic As this bug's fix is also verified on Windows 10, 64 bit (comment 18), I am marking this as verified!
You need to log in
before you can comment on or make changes to this bug.
Description
•