1272765 - Quick search engine bar cut off when additional system status bar is active

Status: RESOLVED INACTIVE

(Firefox for iOS :: Browser, defect)

Description

[Vishnu (:malayaleecoder)]

Attachment: Screenshot

Platform : iPhone SE (9.3.1)
Firefox Version : 4.0 (11)

Steps to Reproduce:

1. Make iPhone act as a Personal Hotspot and connect a device to that network.
2. Open Firefox and type anything in the search bar.

The Quick Search Engine bar is seen cut off.

Comment 1

[Vishnu (:malayaleecoder)]

Attachment: Screenshot(updated)

Personal Hotspot connection banner was not visible in the previous attachment.

Comment 2

[Aaron Train [:aaronmt]]

Also visible with an in-call status bar, tested in simulator.

Thanks for the report. Wonder what we can do?

Comment 3

[Aaron Train [:aaronmt]]

Attachment: in-call-status-bar-screenshot

Comment 4

[Brian Nicholson (:bnicholson)]

Steph mentioned wanting to look into this.

Comment 5

[Stephan Leroux [:sleroux]]

Doesn't seem to be related to the notification status bar work I've been doing since this was found on 4.0. We don't account for the extended status bar height when calculating the offset we need to show the search engine bar while the keyboard is up. I'll file a patch with it. 

However, this exposes a larger issue across our app. We have a lot of view controllers that implement the KeyboardHelper/Delegate combination to determine offsets from the keyboard appearing. We use a lot of table views in the app when showing the keyboard and by using UITableViewController instead of UIViewController subclasses we actually get this calculation for free. The table view will automatically shrink/expand to compensate for the keyboard height which would eliminate the need to match animations and move things around. I would expand on this bug to move towards using UITableViewController but since this implements SiteTableViewController that becomes a much larger task. In the future, we should try to use UITableViewController when we can to get this free functionality and in cases that we can't, try to mimic the behavior of shrinking/expanding the content view instead of shifting elements around.