Closed
Bug 1273063
Opened 8 years ago
Closed 8 years ago
ChannelMediaResource::mIsTransportSeekable could be inconsistent with MediaCacheStream::mIsTransportSeekable
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
ChannelMediaResource::mIsTransportSeekable is added in bug 836927 which could be inconsistent with MediaCacheStream::mIsTransportSeekable after ChannelMediaResource::CanClone() because it is not copied but only set in ChannelMediaResource::OnStartRequest(). Hi Chris, Is there any reason for ChannelMediaResource::IsTransportSeekable() not to just return mCacheStream.IsTransportSeekable()?
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(cpearce)
Comment 1•8 years ago
|
||
(In reply to JW Wang [:jwwang] from comment #0) > Is there any reason for ChannelMediaResource::IsTransportSeekable() not to > just return mCacheStream.IsTransportSeekable()? I can't recall any reason why we could not do that. On the face of it, it seems like a good idea.
Flags: needinfo?(cpearce)
Assignee | ||
Comment 2•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f85522ba657
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53422/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53422/
Attachment #8753632 -
Flags: review?(cpearce)
Comment 4•8 years ago
|
||
Comment on attachment 8753632 [details] MozReview Request: Bug 1273063 - remove ChannelMediaResource::mIsTransportSeekable. r=cpearce. https://reviewboard.mozilla.org/r/53422/#review50202 What could possibly go wrong...
Attachment #8753632 -
Flags: review?(cpearce) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/246ada2a36af
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•