Closed Bug 1273389 Opened 8 years ago Closed 6 years ago

Undiscarded changes should probably be handled kind of like if it hadn't been discarded in the first place

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: glandium, Unassigned)

Details

See these two patches:

https://reviewboard.mozilla.org/r/50991/diff/2#index_header

https://reviewboard.mozilla.org/r/53012/diff/1#index_header

They are attached to the same bug, have the same Commit-ID. What apparently happened is that there was a push between both iterations where that last changeset was not there, so mozreview considered it discarded. Now, it's totally detached from the older revisions, and it's not possible to e.g. interdiff, anymore.

Relatedly, its review status was also wrong, either way you look at it:
- if you consider that it has been discarded and as such should be re-reviewed, the r? status was not propagated to bugzilla
- if you consider that its history matters and should be reattached to the previous iterations, the r+ should have been propagated, too.
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.