1273526 - User needs to access the ToC Settings Panel

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Fernando Campo (:fcampo)]

When clicking the 'Settings' button (represented by the gear image), the Settings Panel should be displayed, giving access to the options:

- Change Room Name  || ONLY ROOM OWNER
    Focus on the Room Name field, that becomes editable (same as with click)

- Change my Username
    Takes the user to the specific FTU step where a new Username can be set

- Turn Notifications Off/On
    As it says, toggles the notifications ON or OFF

- Take the Tour
    Relaunches the whole FTU

- Submit Feedback
    Opens a New Tab with the Feedback screen

- Help
    Opens a New Tab with the Firefox Hello Help page

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] fcampo:settings-panel-shared-options > mozilla:akita

Comment 2

[Fernando Campo (:fcampo)]

Comment on attachment 8761378 [details] [review]
[loop] fcampo:settings-panel-shared-options > mozilla:akita

- Moving settings panel to shared views
- Modify options to follow wireframes (but keeping FxAccounts until we decide what to do with it)
- Adding functionality for the standalone side

Comment 3

[GitHub Autolander Bot]

Attachment: [loop] dmose:fcampo-settings-panel-shared-options > mozilla:akita

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8761378 [details] [review]
[loop] fcampo:settings-panel-shared-options > mozilla:akita

Obsoleted by rebased version of PR.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

I've rebased/unconflicted and posted a new PR.  Marking this as blocking akita-catfood, as it creates the UI that allows guests to set their own nicknames.  There seems to be a problem where it doesn't correctly hide some of the items on the guest side, however.

Comment 6

[Fernando Campo (:fcampo)]

Hey Dan, I can take a look at it if you want, which one is not being hidden correctly?

Should we add reviewers to the PR?

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

I can't easily check it from here, but I believe none of them were being hidden.

Adding reviewers sounds like a fine idea.

Comment 8

[Fernando Campo (:fcampo)]

Attachment: ToC-settings_guest_vs_owner

Dan, can you give more details about the options not hiding on the guest side?

I tested the updated patch, and the only entry that should be hiding for guests (change room name) does not show up.

For the rest, even thought functionality is not implemented, no rules for showing/hiding are set, as far as I know

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

You're right; I'm seeing the same thing.  That said, on my machine, at least, it appears that none of the entries in the menu actually do anything, and Tour, Feedback, and Sign In also don't close the menu when you click on them.  So I guess I was sort of expecting those to be hidden.

At this point, I think it's really your call on what to land...

Comment 10

[Fernando Campo (:fcampo)]

Well, it makes sense to, at least, disable the options that have no functionality, if not hidden.

Will do that, and merge.Thanks.

Comment 11

[GitHub Autolander Bot]

Attachment: [loop] fcampo:settings-panel-shared-options > mozilla:akita

Comment 12

[Fernando Campo (:fcampo)]

Comment on attachment 8766983 [details] [review]
[loop] dmose:fcampo-settings-panel-shared-options > mozilla:akita

Adding new PR with:
- disabled state for entries with no functionality (guest).
- rebase problems fixed.

Comment 13

[Fernando Campo (:fcampo)]

merged - https://github.com/mozilla/loop/commit/edd1dc812d943490e785385d067009031ca6eccc

(functional still crashing)