Closed
Bug 1273835
Opened 8 years ago
Closed 8 years ago
Set new cookie but the Expires is wrong by using "cookie list" on developer tool bar.
Categories
(Core :: Networking: Cookies, defect)
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: amchung, Assigned: amchung)
Details
(Whiteboard: [necko-active])
Attachments
(1 file, 2 obsolete files)
1.40 KB,
patch
|
amchung
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) Steps to reproduce: Tested extensively in Firefox 47.0b6 on Mac OSX 10.10.5 1. Enter "www.example.com" 2. Used "cookie set test-1 test" on "Developer Toolbar". 3. Used "cookie list" to confirm cookie information, the expires showed "1/26/1970, 4:27:50 AM". 4. Double confirmed the cookie expires on storage, it showed "1/17/2038, 12:00:00 AM" on storage.
Assignee | ||
Updated•8 years ago
|
Whiteboard: [necko-active]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → amchung
Assignee | ||
Comment 1•8 years ago
|
||
Hi Jason, I have modified the translateExpires() function in devtools/shared/gcli/commands/cookie.js. Because unit that in argument of Date() needs millisecond.
Attachment #8755211 -
Flags: review?(jduell.mcbugs)
Comment 2•8 years ago
|
||
Comment on attachment 8755211 [details] [diff] [review] The cookie 'expires' value needs converting into something more readable. And The unit of expires is sec, the unit that in argument of Date() needs millisecond. Review of attachment 8755211 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch!
Attachment #8755211 -
Flags: review?(jduell.mcbugs) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd46e3955520
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8755211 -
Attachment is obsolete: true
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8757266 -
Attachment is obsolete: true
Attachment #8757268 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/882e4cb1e069
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•