1273913 - |CompositorBridgeParent::IsInCompositorThread| doesn't exist

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This is a follow-up to bug 1273017.

Comment 1

[:gerard-majax]

I already have it in bug 1273520 attachment 8753816 [details] [diff] [review]

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/53516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53516/

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8753858 [details]
MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53516/diff/1-2/

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Alexandre LISSY :gerard-majax from comment #1)
> I already have it in bug 1273520 attachment 8753816 [details] [diff] [review]

You don't. I have your patch applied and it doesn't fix the issue. And the linked attachment doesn't include the required changes.

Comment 5

[:gerard-majax]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #4)
> (In reply to Alexandre LISSY :gerard-majax from comment #1)
> > I already have it in bug 1273520 attachment 8753816 [details] [diff] [review]
> 
> You don't. I have your patch applied and it doesn't fix the issue. And the
> linked attachment doesn't include the required changes.

Oh, looking at your patch, I see it's about MOZ_ASSERT(). I did an opt build, that might explain why. Hence, I'm wondering if you are not missing a couple of bits from what I have in this very same file, about the same kind of changes.

Comment 6

[:gerard-majax]

Oh no, it's another issue, I misread, sorry :)

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8753858 [details]
MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow

https://reviewboard.mozilla.org/r/53516/#review50446

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a9174f53a08

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5a9174f53a08

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a9174f53a08