Closed
Bug 1274051
Opened 8 years ago
Closed 8 years ago
Only enable telemetry logging on non-release builds
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
Requested by Finkle on irc – it'd provide better performance and we can log extras on nightly builds. Useful context: 14:26 <mcomella> mfinkle: re telemetry extras logging (from earlier in the day) – I'm afraid features in the future will add extras logging without considering the privacy considerations. Are we okay risking the privacy of our users on nightly builds? 14:29 <@mfinkle> mcomella: i would say yes 14:29 <@margaret> mcomella: anything we log in an extra we're also uploading to our severs 14:29 <@mfinkle> mcomella: you have a false sense of security by "plugging" a single hole 14:30 <@mfinkle> i bet we are still logging URLs, if you look hard enough 14:32 <mcomella> Fair enough Bonus comment: 14:32 <mcomella> (if we have the cycles) sounds like a larger mission should be to use a logger we can shut on/off at the user's discretion
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53728/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53728/
Attachment #8754106 -
Flags: review?(gkruglov)
Comment 2•8 years ago
|
||
Comment on attachment 8754106 [details] MozReview Request: Bug 1274051 - Only log telemetry in release builds. r=grisha https://reviewboard.mozilla.org/r/53728/#review50552 The code is doing what you want (only logs telemtry in non-release builds), but the commit comment is the exact opposite :-)
Attachment #8754106 -
Flags: review?(gkruglov) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/26baaed1380122098f0fc0cecffd1b85b213b89a Bug 1274051 - Only log telemetry in non-release builds. r=grisha
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/26baaed13801
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•