1274093 - Basic jsworkers gecko app

Status: RESOLVED INCOMPLETE

(Connected Devices Graveyard :: Project Link, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: jsworkers.patch

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: jsworkers.patch

Comment 2

[[:fabrice] Fabrice Desré]

http://bitsparrow.io/ may provide an easy way to serialize and deserialize messages between Rust and JS.

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: jsworkers.patch

Now with very basic ws setup...

Comment 4

[[:fabrice] Fabrice Desré]

Attachment: jsworkers.patch

Comment 5

[[:fabrice] Fabrice Desré]

Attachment: jsworkers.patch

Comment 6

[[:fabrice] Fabrice Desré]

Attachment: jsworkers.patch

Rebased to build on current m-c

Comment 7

[[:fabrice] Fabrice Desré]

Baku, in this patch there are changes to worker code in:
diff --git a/dom/webidl/Worker.webidl b/dom/webidl/Worker.webidl
diff --git a/dom/workers/ScriptLoader.cpp b/dom/workers/ScriptLoader.cpp
diff --git a/dom/workers/WorkerPrivate.cpp b/dom/workers/WorkerPrivate.cpp
diff --git a/dom/workers/WorkerPrivate.h b/dom/workers/WorkerPrivate.h

The goal is to add an optional argument to the ChromeWorker() constructor to specify in which user context we want to run the worker. I'm setting the principal on the WorkerLoadInfo by building a codebasePrincipal but that doesn't seem to work. Any idea what I should do?

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8766858 [details] [diff] [review]
jsworkers.patch

Review of attachment 8766858 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/WorkerPrivate.cpp
@@ +4115,5 @@
> +  if (NS_WARN_IF(NS_FAILED(rv))) {
> +    return nullptr;
> +  }
> +
> +  GetLoadInfo(aGlobal.Context(), nullptr, parent, aScriptURL,

2 things here:

1. GetLoadInfo starts the loading of the script and it creates the principal. So, mPrincipal+attrs should be set into GetLoadInfo.
2. This should return a security error, right? because of https://dxr.mozilla.org/mozilla-central/source/dom/workers/WorkerPrivate.cpp#4291

Comment 9

[[:fabrice] Fabrice Desré]

Right, I made changes to set the principal in GetLoadInfo, and that part works. But we fail later when we check that the loadContext and the loadInfo match, which makes sense since my loading context is a chrome page.

Instead of keep doing terrible hacks I feel I need to have a clean way to create a context to load some local content (a resource:// or chrome:// url) and make it look like it was loaded from a different, remote URL, including https support. This phony page will itself load the worker, and that needs to be same-origin to work. We also need to set the right userContext on this load context.

Baku, any idea if that's doable and where I should start?

Comment 10

[Grass911]

Because your hacking people that's why. How are you a cop??

Comment 11

[[:fabrice] Fabrice Desré]

Attachment: jsworkers.patch

Comment 12

[Karen Ward [:kward]]

Fabrice - can this bug be closed now?

Comment 13

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Resolving per https://bugzilla.mozilla.org/show_bug.cgi?id=1361198