1274115 - crash in tosqep.dll/tosqep64.dll (toshiba av library) 1.0.10.1224

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Spawned from bug 1268905, where a crash signature was added after a fix had already landed, which didn't account for a DLL in this new signature:
[@ tosqep.dll@0x71d9 ] -> TosQEP.dll 1.0.10.1224

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: MozReview Request: Bug 1274115 - Disable D3D11 for TosQEP.dll 1.0.10.1224 - r?cpearce

Review commit: https://reviewboard.mozilla.org/r/53840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53840/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8754209 [details]
MozReview Request: Bug 1274115 - Disable D3D11 for TosQEP.dll 1.0.10.1224 - r?cpearce

https://reviewboard.mozilla.org/r/53840/#review50568

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/518d0d2c8ee3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/518d0d2c8ee3

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8754209 [details]
MozReview Request: Bug 1274115 - Disable D3D11 for TosQEP.dll 1.0.10.1224 - r?cpearce

Approval Request Comment
[Feature/regressing bug #]: D3D11 crashes in 47+
[User impact if declined]: a dozen crashes per week in beta 47.
[Describe test coverage new/current, TreeHerder]: Media tests in try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fa319dea6b6ae756fde468671e5590d77affa93
[Risks and why]: Only a pref change that adds some DLLs; Tiny risk in disabling too many DLLs, but we're falling back to proven D3D9, so it's not so bad.
[String/UUID change made/needed]: None.

Requires uplift of bug 1257028 and bug 1273691 first.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8754209 [details]
MozReview Request: Bug 1274115 - Disable D3D11 for TosQEP.dll 1.0.10.1224 - r?cpearce

Let's uplift to Aurora48 and stabilize before uplifting to Beta47.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/602f7e05f130

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8754209 [details]
MozReview Request: Bug 1274115 - Disable D3D11 for TosQEP.dll 1.0.10.1224 - r?cpearce

Disable D3D11 for some device drivers, this code stabilized on Aurora over the weekend, Beta47+

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a2b81c651c01