1274132 - crashes related to Intel devices

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Spawned from bug 1269204, where crash signatures were added after a fix had already landed, which didn't account for DLLs in these new signatures:
[@ TppRaiseInvalidParameter ] ->
igd10iumd32.dll 10.18.10.3496,
igd10iumd32.dll 10.18.10.4358,
igd10iumd32.dll 10.18.10.4252
igd10iumd32.dll 10.18.14.4112 (ff46.0.1),
igd10iumd32.dll 10.18.10.4276 (ff46.0.1)
igdumdim32.dll 10.18.14.4170 (ff46.0b99),
igdumdim32.dll 10.18.10.4276 igd10iumd32.dll 10.18.10.4276 (ff45.0.2)
(igd10umd64.dll 9.17.10.4229 already moved to bug 1274127)

[@ CVideoProcessor::CLS::FinalConstruct ] ->
igd10iumd32.dll 20.19.15.4409,
igd10iumd32.dll 20.19.15.4380,
igd10iumd32.dll 10.18.15.4256,
igd10iumd32.dll 20.19.15.4360,
igd10iumd32.dll 20.19.15.4390,
igd10iumd32.dll 20.19.15.4331

[@ igd11dxva32.dll@0x3144f ] ->
igd11dxva32.dll 20.19.15.4444, igd10iumd32.dll 20.19.15.4444
igd11dxva32.dll 20.19.15.4424, igd10iumd32.dll 20.19.15.4424

Some of these look like quite recent versions of the igd* DLLs, so I'd like to be a bit more considerate before blindly blacklisting all of them.
Comments&insights welcome.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Anthony, you suggested disabling D3D11 for Toshiba DLLs in bug 1268905 comment 3.
Chris, you followed suit for Intel DLLs in bug 1269204 comment 4.

So far I've blacklisted some Intel DLL versions 9.x, I'll add a few more 9.x and 10.x in bug 1274127.

Now some of these reports point at versions 20.x.
Do you think I should just blacklist these as well, at least until we know more? (from Intel or our own investigations.)

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: MozReview Request: Bug 1274132 - Disable D3D11 for some more recent igd10* DLLs - r?cpearce

Review commit: https://reviewboard.mozilla.org/r/53848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53848/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

The review in comment 2 assumes we all agree to blacklist these DLL versions (see comment 1).

Note that it doesn't include igd11dxva32.dll because for those reports, igd10iumd32.dll was there as well, so no need to duplicate.

Also I didn't include igdumdim32.dll because it only seems to affect FF<46.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Let's blacklist.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8754221 [details]
MozReview Request: Bug 1274132 - Disable D3D11 for some more recent igd10* DLLs - r?cpearce

https://reviewboard.mozilla.org/r/53848/#review50572

Comment 6

[Marco Castelluccio [:marco]]

You'll probably find other versions using this search: https://crash-stats.mozilla.com/search/?product=Firefox&proto_signature=D3D11DXVA2Manager&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature.

I filed bug 1273504 for the NVIDIA ones.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/830a12b195de

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/830a12b195de

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8754221 [details]
MozReview Request: Bug 1274132 - Disable D3D11 for some more recent igd10* DLLs - r?cpearce

Approval Request Comment
[Feature/regressing bug #]: D3D11 crashes in 47+
[User impact if declined]: ~80 crashes per week in beta 47.
[Describe test coverage new/current, TreeHerder]: Media tests in try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fa319dea6b6ae756fde468671e5590d77affa93
[Risks and why]: Only a pref change that adds some DLLs; Tiny risk in disabling too many DLLs, but we're falling back to proven D3D9, so it's not so bad.
[String/UUID change made/needed]: None.

Requires uplift of bug 1257028, bug 1273691, bug 1274115, and bug 1274127 first.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8754221 [details]
MozReview Request: Bug 1274132 - Disable D3D11 for some more recent igd10* DLLs - r?cpearce

Let's uplift to Aurora48 and stabilize before uplifting to Beta47.

Comment 11

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

This fix will also catch igd10iumd32.dll@0x216a88.

Comment 12

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

This fix will also catch:
[@ igd10iumd32.dll@0x56154 ]
[@ igd10iumd32.dll@0x2e108 ]
[@ igd10iumd32.dll@0xae1c6 ]
[@ igd10umd32.dll@0x1ef819 ]
[@ igd10umd32.dll@0x1ef805 ]
[@ igd10iumd32.dll@0x30e47 ]
[@ igd10iumd32.dll@0x216a81 ]

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/efef1c387fcc

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8754221 [details]
MozReview Request: Bug 1274132 - Disable D3D11 for some more recent igd10* DLLs - r?cpearce

Disable D3D11 for some device drivers, this code stabilized on Aurora over the weekend, Beta47+

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/612fbd61b3e1