1274174 - git mozreview only works from root but not subdirectories

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Whenever I try to run "git mozreview push" from a subdirectory it fails with the following error message:

abort: configuration needed; run `git mozreview configure`

Doing the same from the root dir all is fine.

Comment 1

[Mike Hommey [:glandium]]

This is caused by a bug in git 2.8:
http://marc.info/?l=git&m=145973419918524&w=2

The code to get the git directory is confused by that bug:
http://hg.mozilla.org/hgcustom/version-control-tools/file/c03fab1721bd/git/commands/git-mozreview#l61

FWIW, the equivalent code in cinnabar looks like this, and actually works around that bug:
https://github.com/glandium/git-cinnabar/blob/release/cinnabar/git.py#L55

Comment 2

[Mike Hommey [:glandium]]

Ah, in fact, the code in cinnabar does *not* work around that particular bug. It works around another older one.

Comment 3

[Mike Hommey [:glandium]]

Filed the equivalent cinnabar bug:
https://github.com/glandium/git-cinnabar/issues/70

Comment 4

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1274174 - Work around git 2.8 bug in its output for rev-parse --git-common-dir. r=gps

Review commit: https://reviewboard.mozilla.org/r/54098/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54098/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8754615 [details]
MozReview Request: Bug 1274174 - Work around git 2.8 bug in its output for rev-parse --git-common-dir. r=gps

https://reviewboard.mozilla.org/r/54098/#review51266

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/5b5fbaa85dab