1274580 - './mach mochitest -f chrome' fails for Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

$ ./mach mochitest -f chrome
Error running mach:

    ['mochitest', '-f', 'chrome']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: A cross-directory support file path noted in a test manifest does not appear in any other manifest.
 "browser/base/content/test/general/readerModeArticle.html" must appear in another test manifest to specify an install for "!/browser/base/content/test/general/readerModeArticle.html".

  File "/home/gbrown/src/testing/mochitest/mach_commands.py", line 411, in run_mochitest_general
    driver.install_tests(tests)
  File "/home/gbrown/src/python/mozbuild/mozbuild/controller/building.py", line 675, in install_tests
    '_tests', test_objs)
  File "/home/gbrown/src/python/mozbuild/mozbuild/testing.py", line 484, in install_test_files
    _resolve_installs(install_info.deferred_installs, topobjdir, manifest)
  File "/home/gbrown/src/python/mozbuild/mozbuild/testing.py", line 424, in _resolve_installs
    'for "!/%s".' % (path, path))

Comment 1

[Geoff Brown [:gbrown]]

Eitan -- It's not immediately obvious to me why the readerModeArticle.html reference was added in https://hg.mozilla.org/mozilla-central/rev/dbc96a62c1da; is it necessary?

Comment 2

[Eitan Isaacson [:eeejay]]

This is needed in order to pull in that file for the narrate tests. The narrate feature is not available on android ATM, and I am not sure what it would test there. That directory should probably be skipped in android builds.

Comment 3

[Geoff Brown [:gbrown]]

Unfortunately, the failure persists even if the narrate tests are skipped on android.

I don't understand the failure:

Exception: A cross-directory support file path noted in a test manifest does not appear in any other manifest.
 "browser/base/content/test/general/readerModeArticle.html" must appear in another test manifest to specify an install for "!/browser/base/content/test/general/readerModeArticle.html".

readerModeArticle.html does appear in https://hg.mozilla.org/mozilla-central/annotate/c67dc1f9fab8/browser/base/content/test/general/browser.ini#l507.

:cmanchester - Do you know what's happening here?

Comment 4

[Eitan Isaacson [:eeejay]]

I don't think skipping tests will do the trick. The browser.ini is loaded in any case. the entire directory should be excluded with moz.build.

I'm assuming the browser directory is not included in fennec.

Comment 5

[Axel Hecht [:Pike]]

Attachment: MozReview Request: bug 1274580, don't build narrate on Android, r?eeejay

The narrate module in toolkit might be used on Android
at some point, but currently isn't, and the tests also
depend on /browser/.

Review commit: https://reviewboard.mozilla.org/r/54626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54626/

Comment 6

[Axel Hecht [:Pike]]

I dove in to all-tests.json, and found that toolkit/components/narrate/test/browser.ini depends on 

  !/browser/base/content/test/general/readerModeArticle.html

and thus breaks Android.

Eitan, is this the fix you imagined? Are you the right one to review this?

Clearing the needinfo on cmanchester, as I got the tests to run locally (on a artifact build, but still).

Comment 7

[Axel Hecht [:Pike]]

Filed bug 1275002 to investigate using ./mach for the automation test runs, to catch regressions like this before landing.

Comment 8

[Eitan Isaacson [:eeejay]]

Comment on attachment 8755451 [details]
MozReview Request: bug 1274580, don't build narrate on Android, r?eeejay

https://reviewboard.mozilla.org/r/54626/#review51216

This looks right. I'm not a peer in that module, so my review might not count?

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 8755451 [details]
MozReview Request: bug 1274580, don't build narrate on Android, r?eeejay

Let's get an additional review by Margaret.

Comment 10

[:Margaret Leibovic]

Comment on attachment 8755451 [details]
MozReview Request: bug 1274580, don't build narrate on Android, r?eeejay

https://reviewboard.mozilla.org/r/54626/#review52280

Rubber stamp! (If it works for you, it works for me)

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b71c1dcf988a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b71c1dcf988a