Closed
Bug 1275188
Opened 8 years ago
Closed 8 years ago
Check nullptr on getInlineReturnTypeSet
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
INVALID
People
(Reporter: h4writer, Assigned: h4writer)
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
Details | Diff | Splinter Review |
I was just wandering in code, when I noticed that on trackTypeInfoUnchecked(CallInfo&) we assume getInlineReturnTypeSet will be none-null. That is not globally true, though ?maybe? in this case it could be true. However the check is quite easy and removes any doubt...
|
Assignee | |
Comment 1•8 years ago
|
||
Assignee: nobody → hv1989
Attachment #8755729 -
Flags: review?(shu)
|
||
Comment 2•8 years ago
|
||
When does it return nullptr? It seems to call bytecodeTypes -> TypeScript::BytecodeTypes.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Definitely if script->types() is nullptr. Stopped looking further after that. But yeah that shouldn't happen.
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8755729 [details] [diff] [review] Patch Cancelling since bug was marked invalid.
Attachment #8755729 -
Flags: review?(shu)
You need to log in
before you can comment on or make changes to this bug.
Description
•