Closed
Bug 1275586
Opened 8 years ago
Closed 8 years ago
Add description caching tests.
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: yzen, Assigned: yzen)
Details
Attachments
(1 file)
Continuing e10s compatible tests effort: adding description caching tests inspired by https://dxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/test_descr.html
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/55144/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/55144/
Attachment #8756386 -
Flags: review?(eitan)
Updated•8 years ago
|
Attachment #8756386 -
Flags: review?(eitan) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8756386 [details] MozReview Request: Bug 1275586 - adding description caching tests. r=eeejay https://reviewboard.mozilla.org/r/55144/#review51904 This looks great! Big fan.. ::: accessible/tests/browser/browser_caching_description.js:157 (Diff revision 1) > + yield invokeSetAttribute(browser, 'image', attr, value); > + } > + } > + yield onUpdate; > + // When attribute change (alt) triggers reorder event, accessible will > + // become defunct. That's strange behavior. Shouldn't an alt change just be a name change? The tree doesn't change. Does it?
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Eitan Isaacson [:eeejay] from comment #2) > Comment on attachment 8756386 [details] > MozReview Request: Bug 1275586 - adding description caching tests. r=eeejay > > https://reviewboard.mozilla.org/r/55144/#review51904 > > This looks great! Big fan.. > > ::: accessible/tests/browser/browser_caching_description.js:157 > (Diff revision 1) > > + yield invokeSetAttribute(browser, 'image', attr, value); > > + } > > + } > > + yield onUpdate; > > + // When attribute change (alt) triggers reorder event, accessible will > > + // become defunct. > > That's strange behavior. Shouldn't an alt change just be a name change? The > tree doesn't change. Does it? I believe this is specific to image accessibles and alt attributes only. At least that's what comments in original mochitests suggest: whenever alt attribute is removed/added, it triggers show/hide/reorder sequence.
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b505e0c2334
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fbcbc3e1aa5b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•