1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

bug 1275622 changes the name of the updater binary on mac. We should reflect the change in our update verify scripts

Comment 1

[Rail Aliiev [:rail]]

Attachment: MozReview Request: Bug 1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater r=nthomas

Review commit: https://reviewboard.mozilla.org/r/55184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55184/

Comment 2

[Stephen A Pohl [:spohl]]

(In reply to Rail Aliiev [:rail] from comment #0)
> bug 1275622 changes the name of the updater binary on mac. We should reflect
> the change in our update verify scripts

Just to clarify, it's bug 394984 that changed the name of the binary. Bug 1275622 fixes artifact builds that got busted by that change.

Comment 3

[Rail Aliiev [:rail]]

Oh, right..

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8756446 [details]
MozReview Request: Bug 1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater r=nthomas

https://reviewboard.mozilla.org/r/55184/#review52144

Pretty sure you need a fix before landing, but r+ with that.

::: release/common/check_updates.sh:28
(Diff revision 1)
>    fi
>    
>    case $update_platform in
>        Darwin_ppc-gcc | Darwin_Universal-gcc3 | Darwin_x86_64-gcc3 | Darwin_x86-gcc3-u-ppc-i386 | Darwin_x86-gcc3-u-i386-x86_64 | Darwin_x86_64-gcc3-u-i386-x86_64) 
>            platform_dirname="*.app"
> -          updater="Contents/MacOS/updater.app/Contents/MacOS/updater"
> +          updaters="Contents/MacOS/updater.app/Contents/MacOS/updater updater.app/Contents/MacOS/org.mozilla.updater"

Don't you need a Contents/MacOS/ prefix on the new location ?

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8756446 [details]
MozReview Request: Bug 1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater r=nthomas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55184/diff/1-2/

Comment 6

[Rail Aliiev [:rail]]

(In reply to Nick Thomas [:nthomas] from comment #4)
> Don't you need a Contents/MacOS/ prefix on the new location ?

Good catch. Of course I do! Too many Contents/MacOS in the name :)

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8756446 [details]
MozReview Request: Bug 1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater r=nthomas

https://hg.mozilla.org/build/tools/rev/5bc73d00a723

Comment 8

[Rail Aliiev [:rail]]

worked fine in 47.0b9