1275750 - Remove some dead code in imgFrame

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

There is some dead code laying around in imgFrame. Let's get rid of it.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 1) - Remove unused ScalingData-related code.

ScalingData isn't used anywhere, because the old HQ scaling code has been
completely removed and replaced with downscale-during-decode.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 2) - Remove unused GetDrawTarget()-related code.

GetDrawTarget() isn't used anywhere; VectorImage used to use it, but it now uses
imgFrame::InitWithDrawable(). GetStride() can also be removed since only
GetDrawTarget() uses it.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 3) - Remove imgFrame::GetFormat().

Nothing uses GetFormat().

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8756612 [details] [diff] [review]
(Part 1) - Remove unused ScalingData-related code.

Review of attachment 8756612 [details] [diff] [review]:
-----------------------------------------------------------------

yay

Comment 5

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8756613 [details] [diff] [review]
(Part 2) - Remove unused GetDrawTarget()-related code.

Review of attachment 8756613 [details] [diff] [review]:
-----------------------------------------------------------------

woo

Comment 6

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8756614 [details] [diff] [review]
(Part 3) - Remove imgFrame::GetFormat().

Review of attachment 8756614 [details] [diff] [review]:
-----------------------------------------------------------------

<3 removing code

Comment 7

[Seth Fowler [:seth] [:s2h]]

Thanks for the reviews, Edwin!

Comment 8

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09070d5abf9f80a20fa9bb8d75c8ba3a253aec13
Bug 1275750 (Part 1) - Remove unused ScalingData-related code. r=edwin

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c4ec7324278eabb7a00fcd9c11191fd699feb40
Bug 1275750 (Part 2) - Remove unused GetDrawTarget()-related code. r=edwin

https://hg.mozilla.org/integration/mozilla-inbound/rev/945c510ffa9b4af93cb438331af18ac82f4db59c
Bug 1275750 (Part 3) - Remove imgFrame::GetFormat(). r=edwin

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09070d5abf9f
https://hg.mozilla.org/mozilla-central/rev/7c4ec7324278
https://hg.mozilla.org/mozilla-central/rev/945c510ffa9b